You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by "halyssonJr (via GitHub)" <gi...@apache.org> on 2023/10/18 23:57:07 UTC

[PR] Add ESP32-2432S028 board [nuttx]

halyssonJr opened a new pull request, #10976:
URL: https://github.com/apache/nuttx/pull/10976

   ## Summary
   Add new board ES32-2432S028 board (Reference : https://www.openhasp.com/0.7.0/hardware/sunton/esp32-2432s028/)
   ## Impact
   New feature
   ## Testing
   Pass CI
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Add ESP32-2432S028 board [nuttx]

Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 commented on PR #10976:
URL: https://github.com/apache/nuttx/pull/10976#issuecomment-1771346650

   @halyssonJr run `./tools/checkpatch.sh -g HEAD~...HEAD` to fix the ci error:
   ```
     Normalize esp32-2432S028/nsh
   8d7
   < # CONFIG_ARCH_LEDS is not set
   Saving the new configuration file
   HEAD detached at pull/10976/merge
   Changes not staged for commit:
     (use "git add <file>..." to update what will be committed)
     (use "git restore <file>..." to discard changes in working directory)
   	modified:   boards/xtensa/esp32/esp32-2432S028/configs/nsh/defconfig
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Add ESP32-2432S028 board [nuttx]

Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 commented on PR #10976:
URL: https://github.com/apache/nuttx/pull/10976#issuecomment-1770065655

   @halyssonJr please rebase your patch, ci broken is fixed by https://github.com/apache/nuttx/pull/10975.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Add ESP32-2432S028 board [nuttx]

Posted by "halyssonJr (via GitHub)" <gi...@apache.org>.
halyssonJr commented on PR #10976:
URL: https://github.com/apache/nuttx/pull/10976#issuecomment-1773783499

   @xiaoxiang781216 , This board uses the driver ILI9341, if you check the implementation on ESP32 (`nuttx/boards/xtensa/esp32/common/src/esp32_ili9341.c`), you see we don't have a config or function to turn on the backlight using GPIO.  Because of this, I need to add(`esp32_gpiowrite(DISPLAY_BCKL, true)`)  to turn on the backlight and run the LVGL example. Do you have any suggestions I can do that?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Add ESP32-2432S028 board [nuttx]

Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 merged PR #10976:
URL: https://github.com/apache/nuttx/pull/10976


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Add ESP32-2432S028 board [nuttx]

Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 commented on PR #10976:
URL: https://github.com/apache/nuttx/pull/10976#issuecomment-1773627473

   @halyssonJr sorry, I suggest the wrong command, please try: `./tools/refresh.sh --silent esp32-2432S028/nsh`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Add ESP32-2432S028 board [nuttx]

Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 commented on PR #10976:
URL: https://github.com/apache/nuttx/pull/10976#issuecomment-1773785980

   > @xiaoxiang781216 , This board uses the driver ILI9341, if you check the implementation on ESP32 (`nuttx/boards/xtensa/esp32/common/src/esp32_ili9341.c`), you see we don't have a config or function to turn on the backlight using GPIO. Because of this, I need to add(`esp32_gpiowrite(DISPLAY_BCKL, true)`) to turn on the backlight and run the LVGL example. Do you have any suggestions I can do that? Maybe create a new CONFIG?
   
   Yes, new CONFIG is one of method. @acassis do you have better suggestion?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org