You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@kyuubi.apache.org by "imperio-wxm (via GitHub)" <gi...@apache.org> on 2023/04/27 16:00:52 UTC

[GitHub] [kyuubi] imperio-wxm opened a new issue, #4778: [Bug] kyuubi-server package missing mysql dependency jar

imperio-wxm opened a new issue, #4778:
URL: https://github.com/apache/kyuubi/issues/4778

   ### Code of Conduct
   
   - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
   
   
   ### Search before asking
   
   - [X] I have searched in the [issues](https://github.com/apache/kyuubi/issues?q=is%3Aissue) and found no similar issues.
   
   
   ### Describe the bug
   
   When `kyuubi.metadata.store.jdbc.database.type=MYSQL` is set, kyuubi-server starts to report an error.
   ```java
   Caused by: java.lang.RuntimeException: Failed to load driver class com.mysql.jdbc.Driver in either of HikariConfig class loader or Thread context classloader
   ```
   Log in to the kyuubi-server host to view the dependent jars in the `/opt/kyuubi/jars` directory, and find that the mysql dependency is missing.
   
   In the pom.xml file of kyuubi-server, the scope that mysql depends on is test.
   ```xml
   <dependency>
       <groupId>com.mysql</groupId>
       <artifactId>mysql-connector-j</artifactId>
       <scope>test</scope>
   </dependency>
   ```
   
   And it is known from the parent pom.xml that the mysql jdbc version is `<mysql.jdbc.version>8.0.32</mysql.jdbc.version>`. 
   It is more appropriate to replace `com.mysql.jdbc.Driver` with `com.mysql.cj.jdbc.Driver`
   
   ### Affects Version(s)
   
   master/1.7.0
   
   ### Kyuubi Server Log Output
   
   _No response_
   
   ### Kyuubi Engine Log Output
   
   _No response_
   
   ### Kyuubi Server Configurations
   
   _No response_
   
   ### Kyuubi Engine Configurations
   
   _No response_
   
   ### Additional context
   
   _No response_
   
   ### Are you willing to submit PR?
   
   - [X] Yes. I would be willing to submit a PR with guidance from the Kyuubi community to fix.
   - [ ] No. I cannot submit a PR at this time.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org


[GitHub] [kyuubi] bowenliang123 commented on issue #4778: [Bug] kyuubi-server package missing mysql dependency jar

Posted by "bowenliang123 (via GitHub)" <gi...@apache.org>.
bowenliang123 commented on issue #4778:
URL: https://github.com/apache/kyuubi/issues/4778#issuecomment-1526861585

   -1.
   I think Kyuubi is not shipped with MySql JDBC Driver on purpose.
   1. Mysql JDBC driver follows a different license, the GPLv2
   2. Mysql support for metadata is an optional feature to Kyuubi server
   3. Should not ship with a specific version of Mysql 5 or 8


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org


[GitHub] [kyuubi] imperio-wxm commented on issue #4778: [Bug] kyuubi-server package missing mysql dependency jar

Posted by "imperio-wxm (via GitHub)" <gi...@apache.org>.
imperio-wxm commented on issue #4778:
URL: https://github.com/apache/kyuubi/issues/4778#issuecomment-1525974431

   PR: https://github.com/apache/kyuubi/pull/4779


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org


[GitHub] [kyuubi] bowenliang123 commented on issue #4778: [Bug] kyuubi-server package missing mysql dependency jar

Posted by "bowenliang123 (via GitHub)" <gi...@apache.org>.
bowenliang123 commented on issue #4778:
URL: https://github.com/apache/kyuubi/issues/4778#issuecomment-1531608766

   Closing this issue with discussion and clarification above.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org


[GitHub] [kyuubi] bowenliang123 closed issue #4778: [Bug] kyuubi-server package missing mysql dependency jar

Posted by "bowenliang123 (via GitHub)" <gi...@apache.org>.
bowenliang123 closed issue #4778: [Bug] kyuubi-server package missing mysql dependency jar
URL: https://github.com/apache/kyuubi/issues/4778


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org


[GitHub] [kyuubi] pan3793 commented on issue #4778: [Bug] kyuubi-server package missing mysql dependency jar

Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on issue #4778:
URL: https://github.com/apache/kyuubi/issues/4778#issuecomment-1526946506

   Please read the [ASF 3RD PARTY LICENSE POLICY](https://www.apache.org/legal/resolved.html#category-x)
   
   In short, projects under ASF are prohibited by LAW from including the MySQL JDBC driver in their binary release artifacts.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org


[GitHub] [kyuubi] bowenliang123 commented on issue #4778: [Bug] kyuubi-server package missing mysql dependency jar

Posted by "bowenliang123 (via GitHub)" <gi...@apache.org>.
bowenliang123 commented on issue #4778:
URL: https://github.com/apache/kyuubi/issues/4778#issuecomment-1526941579

   As for 1, we must prevent introducing license violation and the dependency  contamination.  "Many people install kyuubi directly through the release package" you mentioned is just not the general case, as for Mysql 5 or 8 users. They will be both confused by the packed Mysql JDBC driver version and detail of it. And again, license issue.
   Reply to 2, Docker image is NOT evidence for distributed packages itself, which is only an assemble WITH the distributed tarball.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org


[GitHub] [kyuubi] imperio-wxm commented on issue #4778: [Bug] kyuubi-server package missing mysql dependency jar

Posted by "imperio-wxm (via GitHub)" <gi...@apache.org>.
imperio-wxm commented on issue #4778:
URL: https://github.com/apache/kyuubi/issues/4778#issuecomment-1526937551

   1. It is strange if mysql is an option, but users cannot work on it. Many people install kyuubi directly through the release package(.tgz), which means need to manually copy the mysql dependency to the jars directory before deploying.
   
   2. And maybe kyuubi officially provides the docker image in the docker hub, does it mean that users who use docker deployment need to package the image themselves? https://github.com/apache/kyuubi-docker


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org