You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@felix.apache.org by "Graham Jenson (JIRA)" <ji...@apache.org> on 2009/12/04 03:01:20 UTC
[jira] Created: (FELIX-1917) A few minor bugs in the framework
found while embedding Felix
A few minor bugs in the framework found while embedding Felix
-------------------------------------------------------------
Key: FELIX-1917
URL: https://issues.apache.org/jira/browse/FELIX-1917
Project: Felix
Issue Type: Bug
Components: Framework
Affects Versions: felix-2.0.2
Environment: Not an issue (I dont think)
Reporter: Graham Jenson
Priority: Minor
First Bug
org.apache.felix.framework.util.manifestparser.Requirement.toString() method can throw null pointer exception if the requirement does not have a filter.
Second Bug
org.apache.felix.framework.ExtensionManager.loadDefaultSystemPackages() method throws null pointer on variable propURL if there is no default.properties file.
Fix, check if null before.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (FELIX-1917) A few minor bugs in the framework
found while embedding Felix
Posted by "Richard S. Hall (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-1917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12786149#action_12786149 ]
Richard S. Hall commented on FELIX-1917:
----------------------------------------
Regarding the first bug, I don't think this is an error due to a missing filter, I think it is actually an error due to invalid filter syntax. Requirement.toString() calls getFilter() which calls convertToFilter() if there is no filter. If the resulting filter has invalid syntax, then null is returned. Normally it shouldn't have invalid syntax, but there was a bug in handling classes in the default package which would result in filter "(package=)" which is incorrect. I fixed the default package bug in FELIX-1867, so perhaps that will resolve this issue too. If you are seeing it still with trunk, could you explain how to reproduce?
Regarding the second bug, you are correct, it makes sense to check for null. I commit this fix. Thanks.
> A few minor bugs in the framework found while embedding Felix
> -------------------------------------------------------------
>
> Key: FELIX-1917
> URL: https://issues.apache.org/jira/browse/FELIX-1917
> Project: Felix
> Issue Type: Bug
> Components: Framework
> Affects Versions: felix-2.0.2
> Environment: Not an issue (I dont think)
> Reporter: Graham Jenson
> Priority: Minor
> Attachments: Patch.txt
>
> Original Estimate: 0.03h
> Remaining Estimate: 0.03h
>
> First Bug
> org.apache.felix.framework.util.manifestparser.Requirement.toString() method can throw null pointer exception if the requirement does not have a filter.
> Second Bug
> org.apache.felix.framework.ExtensionManager.loadDefaultSystemPackages() method throws null pointer on variable propURL if there is no default.properties file.
> Fix, check if null before.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (FELIX-1917) A few minor bugs in the framework
found while embedding Felix
Posted by "Graham Jenson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-1917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12788915#action_12788915 ]
Graham Jenson commented on FELIX-1917:
--------------------------------------
The first bug is difficult to replicate, the second has been fixed.
> A few minor bugs in the framework found while embedding Felix
> -------------------------------------------------------------
>
> Key: FELIX-1917
> URL: https://issues.apache.org/jira/browse/FELIX-1917
> Project: Felix
> Issue Type: Bug
> Components: Framework
> Affects Versions: felix-2.0.2
> Environment: Not an issue (I dont think)
> Reporter: Graham Jenson
> Priority: Minor
> Fix For: felix-2.2.0
>
> Attachments: Patch.txt
>
> Original Estimate: 0.03h
> Remaining Estimate: 0.03h
>
> First Bug
> org.apache.felix.framework.util.manifestparser.Requirement.toString() method can throw null pointer exception if the requirement does not have a filter.
> Second Bug
> org.apache.felix.framework.ExtensionManager.loadDefaultSystemPackages() method throws null pointer on variable propURL if there is no default.properties file.
> Fix, check if null before.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (FELIX-1917) A few minor bugs in the framework
found while embedding Felix
Posted by "Graham Jenson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-1917?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Graham Jenson updated FELIX-1917:
---------------------------------
Comment: was deleted
(was: The first bug is difficult to replicate, the second has been fixed. )
> A few minor bugs in the framework found while embedding Felix
> -------------------------------------------------------------
>
> Key: FELIX-1917
> URL: https://issues.apache.org/jira/browse/FELIX-1917
> Project: Felix
> Issue Type: Bug
> Components: Framework
> Affects Versions: felix-2.0.2
> Environment: Not an issue (I dont think)
> Reporter: Graham Jenson
> Priority: Minor
> Fix For: felix-2.2.0
>
> Attachments: Patch.txt
>
> Original Estimate: 0.03h
> Remaining Estimate: 0.03h
>
> First Bug
> org.apache.felix.framework.util.manifestparser.Requirement.toString() method can throw null pointer exception if the requirement does not have a filter.
> Second Bug
> org.apache.felix.framework.ExtensionManager.loadDefaultSystemPackages() method throws null pointer on variable propURL if there is no default.properties file.
> Fix, check if null before.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (FELIX-1917) A few minor bugs in the framework found
while embedding Felix
Posted by "Graham Jenson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-1917?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Graham Jenson closed FELIX-1917.
--------------------------------
Resolution: Fixed
Fix Version/s: felix-2.2.0
The first bug is difficult/impossible to reproduce, and the second has been fixed.
> A few minor bugs in the framework found while embedding Felix
> -------------------------------------------------------------
>
> Key: FELIX-1917
> URL: https://issues.apache.org/jira/browse/FELIX-1917
> Project: Felix
> Issue Type: Bug
> Components: Framework
> Affects Versions: felix-2.0.2
> Environment: Not an issue (I dont think)
> Reporter: Graham Jenson
> Priority: Minor
> Fix For: felix-2.2.0
>
> Attachments: Patch.txt
>
> Original Estimate: 0.03h
> Remaining Estimate: 0.03h
>
> First Bug
> org.apache.felix.framework.util.manifestparser.Requirement.toString() method can throw null pointer exception if the requirement does not have a filter.
> Second Bug
> org.apache.felix.framework.ExtensionManager.loadDefaultSystemPackages() method throws null pointer on variable propURL if there is no default.properties file.
> Fix, check if null before.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (FELIX-1917) A few minor bugs in the framework
found while embedding Felix
Posted by "Graham Jenson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-1917?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Graham Jenson updated FELIX-1917:
---------------------------------
Attachment: Patch.txt
A patch, to fix.
> A few minor bugs in the framework found while embedding Felix
> -------------------------------------------------------------
>
> Key: FELIX-1917
> URL: https://issues.apache.org/jira/browse/FELIX-1917
> Project: Felix
> Issue Type: Bug
> Components: Framework
> Affects Versions: felix-2.0.2
> Environment: Not an issue (I dont think)
> Reporter: Graham Jenson
> Priority: Minor
> Attachments: Patch.txt
>
> Original Estimate: 0.03h
> Remaining Estimate: 0.03h
>
> First Bug
> org.apache.felix.framework.util.manifestparser.Requirement.toString() method can throw null pointer exception if the requirement does not have a filter.
> Second Bug
> org.apache.felix.framework.ExtensionManager.loadDefaultSystemPackages() method throws null pointer on variable propURL if there is no default.properties file.
> Fix, check if null before.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.