You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by josiahsams <gi...@git.apache.org> on 2015/09/21 12:46:41 UTC
[GitHub] spark pull request: [SPARK-10725] [TEST] Add dependencies required...
GitHub user josiahsams opened a pull request:
https://github.com/apache/spark/pull/8847
[SPARK-10725] [TEST] Add dependencies required by HiveSparkSubmitSuite
HiveSparkSubmitSuite under sql/hive project fails with NoClassDefFoundError as follows,
Exception in thread "main" java.lang.NoClassDefFoundError: org.apache.spark.sql.hive.test.TestHiveContext
TestHiveContext class is part of sql_hive jar. Since this jar is not part of the list of dependencies we encounter this issue.
So by adding the respective jar to the dependency list we should be able to successfully run all the tests under HiveSparkSubmitSuite .
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ibmsoe/spark SPARK-10725
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/8847.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #8847
----
commit e81f4f15b3283a1859acc0f6ce0887ff99b6d4ba
Author: Josiah Samuel <jo...@in.ibm.com>
Date: 2015-09-21T10:43:33Z
[SPARK-10725] [TEST] Add dependencies required by HiveSparkSubmitSuite
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-10725] [TEST] Add dependencies required...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8847#issuecomment-141939162
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-10725] [TEST] Add dependencies required...
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/8847#issuecomment-142081586
Looks like a cyclic dependency, which won't build. Are you sure you don't mean to depend on the test artifacts?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-10725] [TEST] Add dependencies required...
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/8847#issuecomment-141944135
That may be fine but I wonder why Jenkins is not failing - some SBT vs Maven thing? Anyway a test dep is low risk.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-10725] [TEST] Add dependencies required...
Posted by josiahsams <gi...@git.apache.org>.
Github user josiahsams closed the pull request at:
https://github.com/apache/spark/pull/8847
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-10725] [TEST] Add dependencies required...
Posted by josiahsams <gi...@git.apache.org>.
Github user josiahsams commented on the pull request:
https://github.com/apache/spark/pull/8847#issuecomment-141949246
We primarily use maven for building Spark.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-10725] [TEST] Add dependencies required...
Posted by josiahsams <gi...@git.apache.org>.
Github user josiahsams commented on the pull request:
https://github.com/apache/spark/pull/8847#issuecomment-142240785
JIRA SPARK-9284 has already addressed the issue by including the "classes" directory along with the "test-classes" directory while running tests. So I will be canceling this pull request.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-10725] [TEST] Add dependencies required...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8847#issuecomment-142074732
[Test build #1781 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/1781/console) for PR 8847 at commit [`e81f4f1`](https://github.com/apache/spark/commit/e81f4f15b3283a1859acc0f6ce0887ff99b6d4ba).
* This patch **fails to build**.
* This patch merges cleanly.
* This patch adds no public classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-10725] [TEST] Add dependencies required...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8847#issuecomment-142074435
[Test build #1781 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/1781/consoleFull) for PR 8847 at commit [`e81f4f1`](https://github.com/apache/spark/commit/e81f4f15b3283a1859acc0f6ce0887ff99b6d4ba).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org