[camel] branch master updated: DefaultProducerTemplate#getExecutorService: Small refactoring to avoid false positive "Race condition in double-checked locking object initialization" warning on lgtm.com.

[pa...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

pascalschumacher pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/camel.git


The following commit(s) were added to refs/heads/master by this push:
     new 246cc11  DefaultProducerTemplate#getExecutorService: Small refactoring to avoid false positive "Race condition in double-checked locking object initialization" warning on lgtm.com.
246cc11 is described below

commit 246cc1182f4ddeafcdd985b2bc73a792c780218f
Author: Pascal Schumacher <pa...@gmx.net>
AuthorDate: Sun Mar 29 11:58:19 2020 +0200

    DefaultProducerTemplate#getExecutorService: Small refactoring to avoid false positive "Race condition in double-checked locking object initialization" warning on lgtm.com.
---
 .../java/org/apache/camel/impl/engine/DefaultProducerTemplate.java    | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/core/camel-base/src/main/java/org/apache/camel/impl/engine/DefaultProducerTemplate.java b/core/camel-base/src/main/java/org/apache/camel/impl/engine/DefaultProducerTemplate.java
index 02fcbc6..ec30247 100644
--- a/core/camel-base/src/main/java/org/apache/camel/impl/engine/DefaultProducerTemplate.java
+++ b/core/camel-base/src/main/java/org/apache/camel/impl/engine/DefaultProducerTemplate.java
@@ -782,8 +782,8 @@ public class DefaultProducerTemplate extends ServiceSupport implements ProducerT
             synchronized (lock) {
                 if (executor == null) {
                     if (threadedAsyncMode) {
-                        executor = camelContext.getExecutorServiceManager().newDefaultThreadPool(this, "ProducerTemplate");
-                        ObjectHelper.notNull(executor, "ExecutorService");
+                        executor = ObjectHelper.notNull(camelContext.getExecutorServiceManager().newDefaultThreadPool(this, "ProducerTemplate"),
+                                "ExecutorService");
                     } else {
                         executor = new SynchronousExecutorService();
                     }