You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@grails.apache.org by "borinquenkid (via GitHub)" <gi...@apache.org> on 2026/10/18 13:42:16 UTC
[PR] Compare projectPath against an OS-specific path in FileSystemInteractionImplSpec [grails-core]
borinquenkid opened a new pull request, #16670:
URL: https://github.com/apache/grails-core/pull/16670
The feature method added in 81e4dc8373 (`files that do not exist yet are resolved like existing ones`) asserts `projectPath(missing) == 'nested/missing.txt'`, but `projectPath` returns the canonical path relative to the base directory with the platform separator, so the assertion fails on Windows with `nested\missing.txt`. Every Windows job on every branch from 7.0.x up fails it; the branch push runs were cancelled, so it first surfaced on #16572 (`Build Grails-Core (Windows JDK 25 shard 2)`).
Compares against `new File('nested', 'missing.txt').path` instead, in both copies of the spec on 7.0.x (`grails-core` and `grails-shell-cli`).
Merge-up note: 8.0.x and later have a third copy, `grails-core/src/test-cli/.../FileSystemInteractionImplSpec.groovy`, that needs the same one-line change.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@grails.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Compare projectPath against an OS-specific path in FileSystemInteractionImplSpec [grails-core]
Posted by "borinquenkid (via GitHub)" <gi...@apache.org>.
borinquenkid closed pull request #16670: Compare projectPath against an OS-specific path in FileSystemInteractionImplSpec
URL: https://github.com/apache/grails-core/pull/16670
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@grails.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Compare projectPath against an OS-specific path in FileSystemInteractionImplSpec [grails-core]
Posted by "borinquenkid (via GitHub)" <gi...@apache.org>.
borinquenkid commented on PR #16670:
URL: https://github.com/apache/grails-core/pull/16670#issuecomment-6250823860
Superseded by #16664, which already carries the identical change from 7.2.x upward; 7.0.x/7.1.x will pick it up through the normal merge-up when needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@grails.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Compare projectPath against an OS-specific path in FileSystemInteractionImplSpec [grails-core]
Posted by "borinquenkid (via GitHub)" <gi...@apache.org>.
borinquenkid commented on PR #16670:
URL: https://github.com/apache/grails-core/pull/16670#issuecomment-6250798933
This is the same one-line change as #16664 (merged on 7.2.x and carried up to 9.0.x by #16666–#16668), applied to the two branches that PR did not cover: 7.0.x, where the spec was introduced in 81e4dc8373, and 7.1.x via the normal merge-up. The lines are identical to #16664, so merging 7.0.x into 7.2.x stays conflict-free. Close this if 7.0.x/7.1.x are not meant to get it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@grails.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org