You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@bookkeeper.apache.org by GitBox <gi...@apache.org> on 2020/06/03 15:49:04 UTC
[GitHub] [bookkeeper] eolivelli opened a new pull request #2353: Prototype patch about disable ensamble change
eolivelli opened a new pull request #2353:
URL: https://github.com/apache/bookkeeper/pull/2353
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] eolivelli commented on pull request #2353: Prototype patch about disable ensamble change
Posted by GitBox <gi...@apache.org>.
eolivelli commented on pull request #2353:
URL: https://github.com/apache/bookkeeper/pull/2353#issuecomment-638285048
this is only a prototype,
original patch contributed by @jvrao
I have created this Pr in order to run tests on CI
This patch is not meant to be committed
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] eolivelli commented on pull request #2353: Prototype patch about disable ensamble change
Posted by GitBox <gi...@apache.org>.
eolivelli commented on pull request #2353:
URL: https://github.com/apache/bookkeeper/pull/2353#issuecomment-638642156
@jvrao all tests passed with your patch.
So it looks like that actually resending the write is useless (or we do not have tests that covered that scenario)
In my opinion it makes sense to complete the work, by adding specific tests cases around your change.
cc @Ghatage @karanmehta93 @mino181295
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] eolivelli closed pull request #2353: Prototype patch about non resending writes in case of "disable ensemble change"
Posted by GitBox <gi...@apache.org>.
eolivelli closed pull request #2353:
URL: https://github.com/apache/bookkeeper/pull/2353
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org