You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@wink.apache.org by "Mike Rheinheimer (JIRA)" <ji...@apache.org> on 2009/07/13 21:03:14 UTC
[jira] Created: (WINK-82) getContextResolver sort algorithm is
incorrect
getContextResolver sort algorithm is incorrect
----------------------------------------------
Key: WINK-82
URL: https://issues.apache.org/jira/browse/WINK-82
Project: Wink
Issue Type: Bug
Components: Common
Affects Versions: 0.1
Reporter: Mike Rheinheimer
Fix For: 0.1
Attachments: WINK-82.patch
This is a followup to WINK-47. The sort algorithm for the list of context resolvers is incorrect:
1) does not account for subtype sorting when comparing star/star with text/star
2) sort is backwards -- see patch test, fix, and code comments
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (WINK-82) getContextResolver sort algorithm is
incorrect
Posted by "Michael Elman (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WINK-82?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Michael Elman resolved WINK-82.
-------------------------------
Resolution: Fixed
I've applied Mike's patch with some changes. I hope that sort algorithm is now more clear and bug-free :)
I think that assigning issues to a people is not a good idea. You can never be sure that people are available to take care of these issues, they may be busy with other stuff, OOO and so on.
> getContextResolver sort algorithm is incorrect
> ----------------------------------------------
>
> Key: WINK-82
> URL: https://issues.apache.org/jira/browse/WINK-82
> Project: Wink
> Issue Type: Bug
> Components: Common
> Affects Versions: 0.1
> Reporter: Mike Rheinheimer
> Assignee: Michael Elman
> Fix For: 0.1
>
> Attachments: WINK-82.patch
>
>
> This is a followup to WINK-47. The sort algorithm for the list of context resolvers is incorrect:
> 1) does not account for subtype sorting when comparing text/plain with text/star, for example
> 2) sort is backwards -- see patch test, fix, and code comments
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WINK-82) getContextResolver sort algorithm is
incorrect
Posted by "Mike Rheinheimer (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WINK-82?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12730468#action_12730468 ]
Mike Rheinheimer commented on WINK-82:
--------------------------------------
I thought I could assign issues to people, but I guess you can only assign them to yourself, and only if you're a committer?
Anyway, Michael Elman, would you please review this prior to it being committed? -- want to make sure you agree. Thanks much!
> getContextResolver sort algorithm is incorrect
> ----------------------------------------------
>
> Key: WINK-82
> URL: https://issues.apache.org/jira/browse/WINK-82
> Project: Wink
> Issue Type: Bug
> Components: Common
> Affects Versions: 0.1
> Reporter: Mike Rheinheimer
> Fix For: 0.1
>
> Attachments: WINK-82.patch
>
>
> This is a followup to WINK-47. The sort algorithm for the list of context resolvers is incorrect:
> 1) does not account for subtype sorting when comparing star/star with text/star
> 2) sort is backwards -- see patch test, fix, and code comments
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (WINK-82) getContextResolver sort algorithm is
incorrect
Posted by "Michael Elman (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WINK-82?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Michael Elman reassigned WINK-82:
---------------------------------
Assignee: Michael Elman
> getContextResolver sort algorithm is incorrect
> ----------------------------------------------
>
> Key: WINK-82
> URL: https://issues.apache.org/jira/browse/WINK-82
> Project: Wink
> Issue Type: Bug
> Components: Common
> Affects Versions: 0.1
> Reporter: Mike Rheinheimer
> Assignee: Michael Elman
> Fix For: 0.1
>
> Attachments: WINK-82.patch
>
>
> This is a followup to WINK-47. The sort algorithm for the list of context resolvers is incorrect:
> 1) does not account for subtype sorting when comparing text/plain with text/star, for example
> 2) sort is backwards -- see patch test, fix, and code comments
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WINK-82) getContextResolver sort algorithm is
incorrect
Posted by "Mike Rheinheimer (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WINK-82?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mike Rheinheimer updated WINK-82:
---------------------------------
Attachment: WINK-82.patch
Patch can be applied at wink-common
> getContextResolver sort algorithm is incorrect
> ----------------------------------------------
>
> Key: WINK-82
> URL: https://issues.apache.org/jira/browse/WINK-82
> Project: Wink
> Issue Type: Bug
> Components: Common
> Affects Versions: 0.1
> Reporter: Mike Rheinheimer
> Fix For: 0.1
>
> Attachments: WINK-82.patch
>
>
> This is a followup to WINK-47. The sort algorithm for the list of context resolvers is incorrect:
> 1) does not account for subtype sorting when comparing star/star with text/star
> 2) sort is backwards -- see patch test, fix, and code comments
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (WINK-82) getContextResolver sort algorithm is
incorrect
Posted by "Mike Rheinheimer (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WINK-82?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mike Rheinheimer closed WINK-82.
--------------------------------
> getContextResolver sort algorithm is incorrect
> ----------------------------------------------
>
> Key: WINK-82
> URL: https://issues.apache.org/jira/browse/WINK-82
> Project: Wink
> Issue Type: Bug
> Components: Common
> Affects Versions: 0.1
> Reporter: Mike Rheinheimer
> Assignee: Michael Elman
> Fix For: 0.1
>
> Attachments: WINK-82.patch
>
>
> This is a followup to WINK-47. The sort algorithm for the list of context resolvers is incorrect:
> 1) does not account for subtype sorting when comparing text/plain with text/star, for example
> 2) sort is backwards -- see patch test, fix, and code comments
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WINK-82) getContextResolver sort algorithm is
incorrect
Posted by "Mike Rheinheimer (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WINK-82?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mike Rheinheimer updated WINK-82:
---------------------------------
Description:
This is a followup to WINK-47. The sort algorithm for the list of context resolvers is incorrect:
1) does not account for subtype sorting when comparing text/plain with text/star, for example
2) sort is backwards -- see patch test, fix, and code comments
was:
This is a followup to WINK-47. The sort algorithm for the list of context resolvers is incorrect:
1) does not account for subtype sorting when comparing star/star with text/star
2) sort is backwards -- see patch test, fix, and code comments
> getContextResolver sort algorithm is incorrect
> ----------------------------------------------
>
> Key: WINK-82
> URL: https://issues.apache.org/jira/browse/WINK-82
> Project: Wink
> Issue Type: Bug
> Components: Common
> Affects Versions: 0.1
> Reporter: Mike Rheinheimer
> Fix For: 0.1
>
> Attachments: WINK-82.patch
>
>
> This is a followup to WINK-47. The sort algorithm for the list of context resolvers is incorrect:
> 1) does not account for subtype sorting when comparing text/plain with text/star, for example
> 2) sort is backwards -- see patch test, fix, and code comments
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.