You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2023/01/10 20:26:02 UTC

[GitHub] [beam] johnjcasey commented on a diff in pull request #24964: Fix kafka performance test write failing due to server overwhelmed

johnjcasey commented on code in PR #24964:
URL: https://github.com/apache/beam/pull/24964#discussion_r1066290860


##########
sdks/java/io/kafka/src/main/java/org/apache/beam/sdk/io/kafka/KafkaWriter.java:
##########
@@ -42,13 +42,16 @@
  */
 class KafkaWriter<K, V> extends DoFn<ProducerRecord<K, V>, Void> {
 
+  protected transient @Nullable Callback callback;

Review Comment:
   what is the motivation for a single callback?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org