You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/07/06 00:56:48 UTC

[GitHub] [spark] dongjoon-hyun edited a comment on issue #24948: [SPARK-28093][SQL][FOLLOW-UP] Update trim function behavior changes to migration guide

dongjoon-hyun edited a comment on issue #24948: [SPARK-28093][SQL][FOLLOW-UP] Update trim function behavior changes to migration guide
URL: https://github.com/apache/spark/pull/24948#issuecomment-508885487
 
 
   Since this contains a change on `stringExpressions.scala` together, I'll merge this.
   
   Now, as @wangyum commented in the PR description, this syntax becomes consistent among Spark/PostgreSQL/Presto. Only old Spark 2.x has that behavior.
   
   If Spark 3.0.0 really need to have that old behavior additionally for backward compatibility, please make another PR for that legacy flag, @MaxGekk and @gatorsmile . That PR can be reviewed as a separate item.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org