You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hbase.apache.org by nd...@apache.org on 2021/04/13 16:07:44 UTC
[hbase] branch branch-2.4 updated: HBASE-25653 Add units and round
off region size to 2 digits after decimal (#3046)
This is an automated email from the ASF dual-hosted git repository.
ndimiduk pushed a commit to branch branch-2.4
in repository https://gitbox.apache.org/repos/asf/hbase.git
The following commit(s) were added to refs/heads/branch-2.4 by this push:
new 082ad7c HBASE-25653 Add units and round off region size to 2 digits after decimal (#3046)
082ad7c is described below
commit 082ad7cf21c7063f3e084e7fc7accdaa2d6f3c7f
Author: DivyeshChandra <di...@gmail.com>
AuthorDate: Wed Mar 17 10:02:12 2021 +0530
HBASE-25653 Add units and round off region size to 2 digits after decimal (#3046)
Signed-off-by: stack <st...@duboce.net>
Reviewed-by: Viraj Jasani <vj...@apache.org>
---
.../master/normalizer/SimpleRegionNormalizer.java | 19 +++++++++++--------
1 file changed, 11 insertions(+), 8 deletions(-)
diff --git a/hbase-server/src/main/java/org/apache/hadoop/hbase/master/normalizer/SimpleRegionNormalizer.java b/hbase-server/src/main/java/org/apache/hadoop/hbase/master/normalizer/SimpleRegionNormalizer.java
index 39568bb..291c419 100644
--- a/hbase-server/src/main/java/org/apache/hadoop/hbase/master/normalizer/SimpleRegionNormalizer.java
+++ b/hbase-server/src/main/java/org/apache/hadoop/hbase/master/normalizer/SimpleRegionNormalizer.java
@@ -284,7 +284,7 @@ class SimpleRegionNormalizer implements RegionNormalizer, ConfigurationObserver
double avgRegionSize;
int targetRegionCount = tableDescriptor.getNormalizerTargetRegionCount();
long targetRegionSize = tableDescriptor.getNormalizerTargetRegionSize();
- LOG.debug("Table {} configured with target region count {}, target region size {}", table,
+ LOG.debug("Table {} configured with target region count {}, target region size {} MB", table,
targetRegionCount, targetRegionSize);
if (targetRegionSize > 0) {
@@ -299,8 +299,8 @@ class SimpleRegionNormalizer implements RegionNormalizer, ConfigurationObserver
} else {
avgRegionSize = totalSizeMb / (double) regionCount;
}
- LOG.debug("Table {}, total aggregated regions size: {} and average region size {}", table,
- totalSizeMb, avgRegionSize);
+ LOG.debug("Table {}, total aggregated regions size: {} MB and average region size {} MB",
+ table, totalSizeMb, String.format("%.3f", avgRegionSize));
}
return avgRegionSize;
@@ -351,8 +351,9 @@ class SimpleRegionNormalizer implements RegionNormalizer, ConfigurationObserver
if (avgRegionSizeMb < configuration.getMergeMinRegionSizeMb(ctx)) {
return Collections.emptyList();
}
- LOG.debug("Computing normalization plan for table {}. average region size: {}, number of"
- + " regions: {}.", ctx.getTableName(), avgRegionSizeMb, ctx.getTableRegions().size());
+ LOG.debug("Computing normalization plan for table {}. average region size: {} MB, number of"
+ + " regions: {}.", ctx.getTableName(), avgRegionSizeMb,
+ ctx.getTableRegions().size());
// this nested loop walks the table's region chain once, looking for contiguous sequences of
// regions that meet the criteria for merge. The outer loop tracks the starting point of the
@@ -426,7 +427,8 @@ class SimpleRegionNormalizer implements RegionNormalizer, ConfigurationObserver
*/
private List<NormalizationPlan> computeSplitNormalizationPlans(final NormalizeContext ctx) {
final double avgRegionSize = ctx.getAverageRegionSizeMb();
- LOG.debug("Table {}, average region size: {}", ctx.getTableName(), avgRegionSize);
+ LOG.debug("Table {}, average region size: {} MB", ctx.getTableName(),
+ String.format("%.3f", avgRegionSize));
final List<NormalizationPlan> plans = new ArrayList<>();
for (final RegionInfo hri : ctx.getTableRegions()) {
@@ -435,8 +437,9 @@ class SimpleRegionNormalizer implements RegionNormalizer, ConfigurationObserver
}
final long regionSizeMb = getRegionSizeMB(hri);
if (regionSizeMb > 2 * avgRegionSize) {
- LOG.info("Table {}, large region {} has size {}, more than twice avg size {}, splitting",
- ctx.getTableName(), hri.getRegionNameAsString(), regionSizeMb, avgRegionSize);
+ LOG.info("Table {}, large region {} has size {} MB, more than twice avg size {} MB, "
+ + "splitting", ctx.getTableName(), hri.getRegionNameAsString(), regionSizeMb,
+ String.format("%.3f", avgRegionSize));
plans.add(new SplitNormalizationPlan(hri, regionSizeMb));
}
}