[GitHub] [activemq-artemis] gemmellr commented on a change in pull request #3466: ARTEMIS-3137 support XPath filters

[GitBox <gi...@apache.org>]

gemmellr commented on a change in pull request #3466:
URL: https://github.com/apache/activemq-artemis/pull/3466#discussion_r584650747



##########
File path: artemis-selector/src/main/java/org/apache/activemq/artemis/selector/filter/XPathExpression.java
##########
@@ -79,4 +97,15 @@ public boolean matches(Filterable message) throws FilterException {
       return object == Boolean.TRUE;
    }
 
+   protected static void setupFeatures(DocumentBuilderFactory factory) throws ParserConfigurationException {
+      Properties properties = System.getProperties();
+      for (Map.Entry<Object, Object> prop : properties.entrySet()) {
+         String key = (String) prop.getKey();
+         if (key.startsWith(DOCUMENT_BUILDER_FACTORY_FEATURE)) {
+            String uri = key.split(DOCUMENT_BUILDER_FACTORY_FEATURE + ":")[1];

Review comment:
       Sure, but adding stuff to a fresh codebase is a good time to actually tidy it up and fix things. Rather than introducing it as-is, meaning it likely never happens and folks have to see it and/or possibly hit it later. Essentially, if a trivial bug/improvement is easily spotted in review, and people are being asked to review...




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org