You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@isis.apache.org by da...@apache.org on 2015/09/15 08:03:16 UTC

[11/50] [abbrv] isis git commit: ISIS-1194: inlining runnable impl's in IsisLifecycleListener2

ISIS-1194: inlining runnable impl's in IsisLifecycleListener2


Project: http://git-wip-us.apache.org/repos/asf/isis/repo
Commit: http://git-wip-us.apache.org/repos/asf/isis/commit/e0363f69
Tree: http://git-wip-us.apache.org/repos/asf/isis/tree/e0363f69
Diff: http://git-wip-us.apache.org/repos/asf/isis/diff/e0363f69

Branch: refs/heads/master
Commit: e0363f69a0c35dff8ee3956ba68294302a3154de
Parents: 6243d52
Author: Dan Haywood <da...@haywood-associates.co.uk>
Authored: Fri Sep 11 18:53:36 2015 +0100
Committer: Dan Haywood <da...@haywood-associates.co.uk>
Committed: Mon Sep 14 07:36:05 2015 +0100

----------------------------------------------------------------------
 .../persistence/IsisLifecycleListener2.java     | 60 ++++++++++++--------
 1 file changed, 36 insertions(+), 24 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/isis/blob/e0363f69/core/runtime/src/main/java/org/apache/isis/core/runtime/system/persistence/IsisLifecycleListener2.java
----------------------------------------------------------------------
diff --git a/core/runtime/src/main/java/org/apache/isis/core/runtime/system/persistence/IsisLifecycleListener2.java b/core/runtime/src/main/java/org/apache/isis/core/runtime/system/persistence/IsisLifecycleListener2.java
index 68a966a..73cbd0d 100644
--- a/core/runtime/src/main/java/org/apache/isis/core/runtime/system/persistence/IsisLifecycleListener2.java
+++ b/core/runtime/src/main/java/org/apache/isis/core/runtime/system/persistence/IsisLifecycleListener2.java
@@ -56,17 +56,32 @@ public class IsisLifecycleListener2
 
     @Override
     public void postCreate(final InstanceLifecycleEvent event) {
-        new RunnableNoop(event).run();
+        final InstanceLifecycleEvent event1 = event;
+        new RunnableAbstract(event1) {
+            protected void doRun() {}
+        }.run();
     }
 
     @Override
     public void preAttach(final InstanceLifecycleEvent event) {
-        new RunnableEnsureRootObject(event).run();
+        final InstanceLifecycleEvent event1 = event;
+        new RunnableAbstract(event1) {
+            protected void doRun() {
+                final Persistable pojo = Utils.persistenceCapableFor(event);
+                persistenceSession.ensureRootObject(pojo);
+            }
+        }.run();
     }
 
     @Override
     public void postAttach(final InstanceLifecycleEvent event) {
-        new RunnableEnsureRootObject(event).run();
+        final InstanceLifecycleEvent event1 = event;
+        new RunnableAbstract(event1) {
+            protected void doRun() {
+                final Persistable pojo = Utils.persistenceCapableFor(event);
+                persistenceSession.ensureRootObject(pojo);
+            }
+        }.run();
     }
 
     @Override
@@ -118,7 +133,10 @@ public class IsisLifecycleListener2
         //
         // 1<->m bidirectional, persistence-by-reachability
 
-        new RunnableNoop(event).run();
+        final InstanceLifecycleEvent event1 = event;
+        new RunnableAbstract(event1) {
+            protected void doRun() {}
+        }.run();
     }
 
     @Override
@@ -162,12 +180,24 @@ public class IsisLifecycleListener2
 
     @Override
     public void preDetach(InstanceLifecycleEvent event) {
-        new RunnableEnsureRootObject(event).run();
+        final InstanceLifecycleEvent event1 = event;
+        new RunnableAbstract(event1) {
+            protected void doRun() {
+                final Persistable pojo = Utils.persistenceCapableFor(event);
+                persistenceSession.ensureRootObject(pojo);
+            }
+        }.run();
     }
 
     @Override
     public void postDetach(InstanceLifecycleEvent event) {
-        new RunnableEnsureRootObject(event).run();
+        final InstanceLifecycleEvent event1 = event;
+        new RunnableAbstract(event1) {
+            protected void doRun() {
+                final Persistable pojo = Utils.persistenceCapableFor(event);
+                persistenceSession.ensureRootObject(pojo);
+            }
+        }.run();
     }
 
     
@@ -193,24 +223,6 @@ public class IsisLifecycleListener2
         
         protected abstract void doRun(); 
     }
-    
-    private class RunnableNoop extends RunnableAbstract {
-        RunnableNoop(InstanceLifecycleEvent event) {
-            super(event);
-        }
-        protected void doRun() {} 
-    }
-    
-    private class RunnableEnsureRootObject extends RunnableAbstract {
-        RunnableEnsureRootObject(InstanceLifecycleEvent event) {
-            super(event);
-        }
-        protected void doRun() {
-            final Persistable pojo = Utils.persistenceCapableFor(event);
-            persistenceSession.ensureRootObject(pojo);
-        }
-    }
-    
 
     // /////////////////////////////////////////////////////////
     // SuspendListener