You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/10/28 02:52:09 UTC

[GitHub] [pulsar] ltamber opened a new pull request #8396: Handle hash collision in KeyShared subscription mode

ltamber opened a new pull request #8396:
URL: https://github.com/apache/pulsar/pull/8396


   ### Motivation
   Currently, in `ConsistentHashingStickyKeyConsumerSelector` key consumer selector，if multi key have the same hash code, the consumer in the `hashRing` will be replaced by the newer consumer,  so the behavior of the message dispatch will not consistent if the consumer subscribed in a different order.
   
   ### Modifications
   
   handle the hash collision with a list.
   
   ### Verifying this change
   
   unit test `ConsistentHashingStickyKeyConsumerSelectorTest` was passed.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] codelipenghui commented on pull request #8396: Handle hash collision in KeyShared subscription mode

Posted by GitBox <gi...@apache.org>.
codelipenghui commented on pull request #8396:
URL: https://github.com/apache/pulsar/pull/8396#issuecomment-717926607


   @ltamber Could you please add some unit test for the new change?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] ltamber commented on pull request #8396: Handle hash collision in KeyShared subscription mode

Posted by GitBox <gi...@apache.org>.
ltamber commented on pull request #8396:
URL: https://github.com/apache/pulsar/pull/8396#issuecomment-717662074


   @jiazhai @codelipenghui PTAL


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] jiazhai commented on pull request #8396: Handle hash collision in KeyShared subscription mode

Posted by GitBox <gi...@apache.org>.
jiazhai commented on pull request #8396:
URL: https://github.com/apache/pulsar/pull/8396#issuecomment-717873346


   /pulsarbot run-failure-checks


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] ltamber commented on pull request #8396: Handle hash collision in KeyShared subscription mode

Posted by GitBox <gi...@apache.org>.
ltamber commented on pull request #8396:
URL: https://github.com/apache/pulsar/pull/8396#issuecomment-718725113


   /pulsarbot run-failure-checks


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] ltamber commented on pull request #8396: Handle hash collision in KeyShared subscription mode

Posted by GitBox <gi...@apache.org>.
ltamber commented on pull request #8396:
URL: https://github.com/apache/pulsar/pull/8396#issuecomment-718322256


   @codelipenghui  It seem that hard to simulate(but it does exist) hash collision when use murmur_3, so I just run the `ConsistentHashingStickyKeyConsumerSelectorTest` unit test  


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] ltamber commented on pull request #8396: Handle hash collision in KeyShared subscription mode

Posted by GitBox <gi...@apache.org>.
ltamber commented on pull request #8396:
URL: https://github.com/apache/pulsar/pull/8396#issuecomment-717872925


   /pulsarbot run-failure-checks


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org