You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by GitBox <gi...@apache.org> on 2020/09/21 15:10:14 UTC
[GitHub] [ignite] gvvinblade commented on a change in pull request #8261: IGNITE-13463 Rework RootNode rows exchange
gvvinblade commented on a change in pull request #8261:
URL: https://github.com/apache/ignite/pull/8261#discussion_r492128618
##########
File path: modules/calcite/src/main/java/org/apache/ignite/internal/processors/query/calcite/exec/rel/RootNode.java
##########
@@ -236,61 +214,55 @@ else if (state == State.END || state == State.CLOSED)
}
/** */
- private Row take() {
+ private void exchangeBuffers() {
assert !F.isEmpty(sources()) && sources().size() == 1;
lock.lock();
try {
while (true) {
- checkCancelled();
- assert state == State.RUNNING;
+ //checkException();
Review comment:
we need this call because without it client code will finish successfully in case it was waiting on a condition at the cancellation time
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org