You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@helix.apache.org by GitBox <gi...@apache.org> on 2020/03/26 18:28:10 UTC
[GitHub] [helix] jiajunwang commented on a change in pull request #869:
Replace customized view cache with property cache
jiajunwang commented on a change in pull request #869: Replace customized view cache with property cache
URL: https://github.com/apache/helix/pull/869#discussion_r398797422
##########
File path: helix-core/src/test/java/org/apache/helix/integration/spectator/TestRoutingTableProvider.java
##########
@@ -308,19 +327,53 @@ public void testGetRoutingTableSnapshot() {
routingTableProvider.getRoutingTableSnapshot(PropertyType.CUSTOMIZEDVIEW, "typeA");
Assert.assertEquals(routingTableSnapshot.getPropertyType(), PropertyType.CUSTOMIZEDVIEW);
Assert.assertEquals(routingTableSnapshot.getCustomizedStateType(), "typeA");
+
routingTableSnapshot =
routingTableProvider.getRoutingTableSnapshot(PropertyType.CUSTOMIZEDVIEW, "typeB");
Assert.assertEquals(routingTableSnapshot.getPropertyType(), PropertyType.CUSTOMIZEDVIEW);
Assert.assertEquals(routingTableSnapshot.getCustomizedStateType(), "typeB");
- Map<String, Map<String, RoutingTableSnapshot>> routingTableSnapshots =
- routingTableProvider.getRoutingTableSnapshots();
- Assert.assertEquals(routingTableSnapshots.size(), 2);
- Assert.assertEquals(routingTableSnapshots.get(PropertyType.CUSTOMIZEDVIEW.name()).size(), 2);
+ // Make sure snapshot information is correct
+ // Check resources are in a correct state
+ boolean isRoutingTableUpdatedProperly = TestHelper.verify(() -> {
+ Map<String, Map<String, RoutingTableSnapshot>> routingTableSnapshots =
+ routingTableProvider.getRoutingTableSnapshots();
+ RoutingTableSnapshot routingTableSnapshotTypeA =
+ routingTableSnapshots.get(PropertyType.CUSTOMIZEDVIEW.name()).get("typeA");
+ RoutingTableSnapshot routingTableSnapshotTypeB =
+ routingTableSnapshots.get(PropertyType.CUSTOMIZEDVIEW.name()).get("typeB");
+ String typeAp1h1 = "noState";
+ String typeAp1h2 = "noState";
+ String typeAp2h1 = "noState";
+ String typeAp3h2 = "noState";
+ String typeBp1h2 = "noState";
+ String typeBp1h4 = "noState";
+ try {
+ typeAp1h1 = routingTableSnapshotTypeA.getCustomizeViews().iterator().next()
+ .getStateMap("p1").get("h1");
+ typeAp1h2 = routingTableSnapshotTypeA.getCustomizeViews().iterator().next()
+ .getStateMap("p1").get("h2");
+ typeAp2h1 = routingTableSnapshotTypeA.getCustomizeViews().iterator().next()
+ .getStateMap("p2").get("h1");
+ typeAp3h2 = routingTableSnapshotTypeA.getCustomizeViews().iterator().next()
+ .getStateMap("p3").get("h2");
+ typeBp1h2 = routingTableSnapshotTypeB.getCustomizeViews().iterator().next()
+ .getStateMap("p1").get("h3");
+ typeBp1h4 = routingTableSnapshotTypeB.getCustomizeViews().iterator().next()
+ .getStateMap("p1").get("h4");
+ } catch (Exception e) {
+ // ok because RoutingTable has not been updated yet
Review comment:
nit, return false directly here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org