[GitHub] [netbeans] JaroslavTulach commented on a change in pull request #2690: Snapshot of APIs for 12.3.

[GitBox <gi...@apache.org>]

JaroslavTulach commented on a change in pull request #2690:
URL: https://github.com/apache/netbeans/pull/2690#discussion_r560646125



##########
File path: java/java.lsp.server/nbproject/org-netbeans-modules-java-lsp-server.sig
##########
@@ -63,6 +63,17 @@ meth public final void setStatusText(java.lang.String)
 supr org.openide.awt.StatusDisplayer
 hfds text
 
+CLSS public abstract org.netbeans.modules.java.lsp.server.ui.AbstractProgressEnvironment

Review comment:
       OK.

##########
File path: ide/projectapi/nbproject/org-netbeans-modules-projectapi.sig
##########
@@ -117,6 +117,10 @@ meth public static java.util.Set<org.netbeans.api.project.Project> getDependency
 meth public static java.util.prefs.Preferences getPreferences(org.netbeans.api.project.Project,java.lang.Class,boolean)
  anno 1 org.netbeans.api.annotations.common.NonNull()
  anno 2 org.netbeans.api.annotations.common.NonNull()
+meth public static org.netbeans.api.project.Project parentOf(org.netbeans.api.project.Project)

Review comment:
       I see. Nicely generalized API originating from Gradle.

##########
File path: platform/api.progress.nb/nbproject/org-netbeans-api-progress-nb.sig
##########
@@ -158,6 +171,8 @@ cons public init()
 meth protected static org.netbeans.api.progress.ProgressHandle getProgressHandle(org.netbeans.api.progress.aggregate.AggregateProgressHandle)
 meth protected static org.netbeans.api.progress.aggregate.AggregateProgressHandle doCreateHandle(java.lang.String,org.netbeans.api.progress.aggregate.ProgressContributor[],org.openide.util.Cancellable,boolean,org.netbeans.api.progress.ProgressHandle)
 meth public static org.netbeans.api.progress.aggregate.AggregateProgressHandle createHandle(java.lang.String,org.netbeans.api.progress.aggregate.ProgressContributor[],org.openide.util.Cancellable)
+meth public static org.netbeans.api.progress.aggregate.AggregateProgressHandle createHandle(java.lang.String,org.netbeans.api.progress.aggregate.ProgressContributor[],org.openide.util.Cancellable,javax.swing.Action)
+meth public static org.netbeans.api.progress.aggregate.AggregateProgressHandle createSystemHandle(java.lang.String,org.netbeans.api.progress.aggregate.ProgressContributor[],org.openide.util.Cancellable,javax.swing.Action)

Review comment:
       OK.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists