[GitHub] flink pull request #4022: [FLINK-5488] stop YarnClient before exception is t...

[zjureel <gi...@git.apache.org>]

Github user zjureel commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4022#discussion_r119779957
  
    --- Diff: flink-yarn/src/main/java/org/apache/flink/yarn/AbstractYarnClusterDescriptor.java ---
    @@ -392,6 +392,7 @@ protected YarnClient getYarnClient() {
     	@Override
     	public YarnClusterClient retrieve(String applicationID) {
     
    +		final YarnClient yarnClient = getYarnClient();
     		try {
     			// check if required Hadoop environment variables are set. If not, warn user
     			if (System.getenv("HADOOP_CONF_DIR") == null &&
    --- End diff --
    
    It's a good point, I will put `getYarnClient()` in the `try` block


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---