You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@s2graph.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/02/19 05:59:18 UTC
[jira] [Commented] (S2GRAPH-31) Remove playframework dependencies
on s2core/build.sbt
[ https://issues.apache.org/jira/browse/S2GRAPH-31?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15153720#comment-15153720 ]
ASF GitHub Bot commented on S2GRAPH-31:
---------------------------------------
GitHub user SteamShon opened a pull request:
https://github.com/apache/incubator-s2graph/pull/16
[S2GRAPH-31] Remove playframework dependencies on s2core/build.sbt
+ remove ws, filters which is not necessary for s2core.
+ add missing netty jar that is missed out on S2GRAPH-9.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/SteamShon/incubator-s2graph S2GRAPH-31
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-s2graph/pull/16.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #16
----
commit 155e8fe2f7f4ea8b05b8e4541ab8aeba12883dc1
Author: DO YUNG YOON <st...@apache.org>
Date: 2016-02-19T04:53:43Z
add missing netty jar that missed out on S2GRAPH-9.
also remove filters, ws which is not necessary for s2core.
----
> Remove playframework dependencies on s2core/build.sbt
> ------------------------------------------------------
>
> Key: S2GRAPH-31
> URL: https://issues.apache.org/jira/browse/S2GRAPH-31
> Project: S2Graph
> Issue Type: Task
> Reporter: DOYUNG YOON
> Assignee: DOYUNG YOON
> Priority: Trivial
> Labels: refactor
>
> After S2GRAPH-6, there is no need for including playframework dependencies on s2core. it would be better to remove unused dependencies on build.sbt for s2core module.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)