You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Greg Mann <gr...@mesosphere.io> on 2018/07/03 21:31:53 UTC

Re: Review Request 66844: Added framework metrics for filtered resources to the allocator.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66844/
-----------------------------------------------------------

(Updated July 3, 2018, 9:31 p.m.)


Review request for mesos, Benjamin Mahler, Gastón Kleiman, Gilbert Song, and Vinod Kone.


Bugs: MESOS-8849
    https://issues.apache.org/jira/browse/MESOS-8849


Repository: mesos


Description
-------

These metrics count the number of times that the allocator has
filtered resources out of this framework's offer stream,
with separate metrics for different types of filtering.


Diffs (updated)
-----

  src/master/allocator/mesos/hierarchical.hpp 0f6c0e96a105c64465d3f5db4ff663d8fdfe7e26 
  src/master/allocator/mesos/hierarchical.cpp 5a6cd3d2fc5bdbaaee2d05b9be9e83d4107c749b 
  src/master/allocator/mesos/metrics.hpp 6d386225c301d5ab44f3cc0ecdd1478fb5162e5b 
  src/master/allocator/mesos/metrics.cpp 82990b2dc0b827a43a392d898667eaf58c77ea36 


Diff: https://reviews.apache.org/r/66844/diff/7/

Changes: https://reviews.apache.org/r/66844/diff/6-7/


Testing (updated)
-------

Testing details can be found at the end of this chain.


Thanks,

Greg Mann


Re: Review Request 66844: Added framework metrics for filtered resources to the allocator.

Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66844/
-----------------------------------------------------------

(Updated July 9, 2018, 3:49 p.m.)


Review request for mesos, Benjamin Mahler, Gastón Kleiman, Gilbert Song, and Vinod Kone.


Bugs: MESOS-8849
    https://issues.apache.org/jira/browse/MESOS-8849


Repository: mesos


Description
-------

These metrics count the number of times that the allocator has
filtered resources out of this framework's offer stream,
with separate metrics for different types of filtering.


Diffs (updated)
-----

  src/master/allocator/mesos/hierarchical.hpp 0f6c0e96a105c64465d3f5db4ff663d8fdfe7e26 
  src/master/allocator/mesos/hierarchical.cpp 5a6cd3d2fc5bdbaaee2d05b9be9e83d4107c749b 
  src/master/allocator/mesos/metrics.hpp 6d386225c301d5ab44f3cc0ecdd1478fb5162e5b 
  src/master/allocator/mesos/metrics.cpp 82990b2dc0b827a43a392d898667eaf58c77ea36 


Diff: https://reviews.apache.org/r/66844/diff/8/

Changes: https://reviews.apache.org/r/66844/diff/7-8/


Testing
-------

Testing details can be found at the end of this chain.


Thanks,

Greg Mann