[GitHub] [calcite] amaliujia commented on a change in pull request #2005: [CALCITE-4041] Implement trait propagation for EnumerableCorrelate

[GitBox <gi...@apache.org>]

amaliujia commented on a change in pull request #2005:
URL: https://github.com/apache/calcite/pull/2005#discussion_r436186347



##########
File path: core/src/main/java/org/apache/calcite/adapter/enumerable/EnumerableCorrelate.java
##########
@@ -81,6 +87,35 @@ public static EnumerableCorrelate create(
         traitSet, left, right, correlationId, requiredColumns, joinType);
   }
 
+  @Override public Pair<RelTraitSet, List<RelTraitSet>> passThroughTraits(
+      final RelTraitSet required) {
+    final RelCollation collation = required.getCollation();
+    if (collation == null || collation == RelCollations.EMPTY) {
+      return null;
+    }

Review comment:
       Not very familiar with `EnumerableCorrelate`, will it need to deal with RIGHT OUTER/FULL OUTER JOIN style case?  




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org