You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/06/12 21:28:13 UTC

[GitHub] [flink] TengHu opened a new pull request #12640: [FLINK-18281] [streaming-java][window-assigners] Add WindowStagger into TumblingEventTimeWindows

TengHu opened a new pull request #12640:
URL: https://github.com/apache/flink/pull/12640


   ## What is the purpose of the change
   
   This PR is a follow-up of [FLINK-12855](https://issues.apache.org/jira/browse/FLINK-12855) and [PR 12297](FLINK-12855), which introduces WindowStagger in TumblingProcessingTimeWindows. 
   
   In this PR, I added the staggering feature into TumblingEventTimeWindows.
   
   ## Brief changelog
     - *Added the staggering feature into TumblingEventTimeWindows*
     - *Added unit test*
   
   ## Verifying this change
   This change added tests and can be verified as follows:
     - *Added test that validates that staggering feature work for tumbling event time window assigner*
   
   ## Does this pull request potentially affect one of the following parts:
      * Dependencies (does it add or upgrade a dependency): no
      * The public API, i.e., is any changed class annotated with @Public(Evolving): yes,    
      * TumblingProcessingTimeWindows(potentially all WindowAssigners)
      * The serializers: no
      * The runtime per-record code paths (performance sensitive): don't know, probably no ?
      * Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: no
      * The S3 file system connector: no
   
   ## Documentation
   
     - Does this pull request introduce a new feature? yes
     - If yes, how is the feature documented? JavaDocs
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] TengHu commented on pull request #12640: [FLINK-18281] [streaming-java][window-assigners] Add WindowStagger into TumblingEventTimeWindows

Posted by GitBox <gi...@apache.org>.
TengHu commented on pull request #12640:
URL: https://github.com/apache/flink/pull/12640#issuecomment-643491078


   @aljoscha Here is a followup change of the [PRR 12297](https://github.com/apache/flink/pull/12297). Thank you


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #12640: [FLINK-18281] [streaming-java][window-assigners] Add WindowStagger into TumblingEventTimeWindows

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #12640:
URL: https://github.com/apache/flink/pull/12640#issuecomment-643492455


   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit 6467aecd71b23dab03c9f6ee1dd5d1d51569e281 (Fri Jun 12 21:34:07 UTC 2020)
   
   **Warnings:**
    * No documentation files were touched! Remember to keep the Flink docs up to date!
    * **This pull request references an unassigned [Jira ticket](https://issues.apache.org/jira/browse/FLINK-18281).** According to the [code contribution guide](https://flink.apache.org/contributing/contribute-code.html), tickets need to be assigned before starting with the implementation work.
   
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] aljoscha commented on pull request #12640: [FLINK-18281] [streaming-java][window-assigners] Add WindowStagger into TumblingEventTimeWindows

Posted by GitBox <gi...@apache.org>.
aljoscha commented on pull request #12640:
URL: https://github.com/apache/flink/pull/12640#issuecomment-664830902






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #12640: [FLINK-18281] [streaming-java][window-assigners] Add WindowStagger into TumblingEventTimeWindows

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12640:
URL: https://github.com/apache/flink/pull/12640#issuecomment-643501688


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "726575fd6fe334be89300f3668fa4a4c23a74b31",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3437",
       "triggerID" : "726575fd6fe334be89300f3668fa4a4c23a74b31",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 726575fd6fe334be89300f3668fa4a4c23a74b31 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3437) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] TengHu commented on pull request #12640: [FLINK-18281] [streaming-java][window-assigners] Add WindowStagger into TumblingEventTimeWindows

Posted by GitBox <gi...@apache.org>.
TengHu commented on pull request #12640:
URL: https://github.com/apache/flink/pull/12640#issuecomment-663882021


   @aljoscha Hi, any update from the discussion


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] TengHu commented on pull request #12640: [FLINK-18281] [streaming-java][window-assigners] Add WindowStagger into TumblingEventTimeWindows

Posted by GitBox <gi...@apache.org>.
TengHu commented on pull request #12640:
URL: https://github.com/apache/flink/pull/12640#issuecomment-647687346


   @aljoscha gentle ping on this


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] aljoscha closed pull request #12640: [FLINK-18281] [streaming-java][window-assigners] Add WindowStagger into TumblingEventTimeWindows

Posted by GitBox <gi...@apache.org>.
aljoscha closed pull request #12640:
URL: https://github.com/apache/flink/pull/12640


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] aljoscha commented on pull request #12640: [FLINK-18281] [streaming-java][window-assigners] Add WindowStagger into TumblingEventTimeWindows

Posted by GitBox <gi...@apache.org>.
aljoscha commented on pull request #12640:
URL: https://github.com/apache/flink/pull/12640#issuecomment-648713521


   Let's wait for the discussion about whether we should add this as a new window type from https://issues.apache.org/jira/browse/FLINK-12855.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] aljoscha commented on pull request #12640: [FLINK-18281] [streaming-java][window-assigners] Add WindowStagger into TumblingEventTimeWindows

Posted by GitBox <gi...@apache.org>.
aljoscha commented on pull request #12640:
URL: https://github.com/apache/flink/pull/12640#issuecomment-648203540


   Sorry for the wait! I think this change is also good. I thought about another thing though: for event-time it could make sense to not modify the window that an element is in, i.e. the staggering doesn't change the actual windows. We could only change the firing timestamp, meaning we would change the trigger we set in `EventTimeTrigger` based on staggering. Potentially we would move the firing timestamp into the future, but never before the original firing timestamp. Did you ever think about this?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] TengHu edited a comment on pull request #12640: [FLINK-18281] [streaming-java][window-assigners] Add WindowStagger into TumblingEventTimeWindows

Posted by GitBox <gi...@apache.org>.
TengHu edited a comment on pull request #12640:
URL: https://github.com/apache/flink/pull/12640#issuecomment-643491078


   @aljoscha Here is a followup change of the [PR 12297](https://github.com/apache/flink/pull/12297). Thank you


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #12640: [FLINK-18281] [streaming-java][window-assigners] Add WindowStagger into TumblingEventTimeWindows

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12640:
URL: https://github.com/apache/flink/pull/12640#issuecomment-643501688


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "726575fd6fe334be89300f3668fa4a4c23a74b31",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3437",
       "triggerID" : "726575fd6fe334be89300f3668fa4a4c23a74b31",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 726575fd6fe334be89300f3668fa4a4c23a74b31 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3437) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #12640: [FLINK-18281] [streaming-java][window-assigners] Add WindowStagger into TumblingEventTimeWindows

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #12640:
URL: https://github.com/apache/flink/pull/12640#issuecomment-643501688


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "726575fd6fe334be89300f3668fa4a4c23a74b31",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "726575fd6fe334be89300f3668fa4a4c23a74b31",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 726575fd6fe334be89300f3668fa4a4c23a74b31 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org