[jira] [Commented] (GEODE-3966) PoolImpl.createAuthenticatedCacheView should not call CacheFactory.getInstance

["ASF subversion and git services (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/GEODE-3966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16352599#comment-16352599 ] 

ASF subversion and git services commented on GEODE-3966:
--------------------------------------------------------

Commit 40a2ca0041e575cd3c21f9fba80f523ce44bc3c1 in geode's branch refs/heads/develop from [~PivotalSarge]
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=40a2ca0 ]

GEODE-3966: Avoid singletons by passing distributed system and cache. (#1366)



> PoolImpl.createAuthenticatedCacheView should not call CacheFactory.getInstance
> ------------------------------------------------------------------------------
>
>                 Key: GEODE-3966
>                 URL: https://issues.apache.org/jira/browse/GEODE-3966
>             Project: Geode
>          Issue Type: Sub-task
>          Components: client/server
>            Reporter: Darrel Schneider
>            Assignee: Michael Dodge
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 1.5h
>  Remaining Estimate: 0h
>
> PoolImpl.createAuthenticatedCacheView should not call CacheFactory.getInstance.
> It looks like it would be easy for all the callers of this method to pass the cache in as a parameter.
> Or maybe an InternalPool should be associated with a Cache already (there are two other uses of CacheFactory.getInstance in this class)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)