You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@logging.apache.org by remkop <gi...@git.apache.org> on 2018/10/16 23:29:09 UTC

[GitHub] logging-log4j2 issue #220: [WIP][LOG4J2-2475] ReusableMessageFactory uses no...

Github user remkop commented on the issue:

    https://github.com/apache/logging-log4j2/pull/220
  
    Good point that we cannot distinguish between parameter arrays created by the user (which we shouldn’t reuse) and parameter arrays created by the compiler because of a varargs invocation. 
    
    Would it be an idea to clone large (size greater than 10) parameter arrays? (And use this cloned array in the reusable message.)
    
    That would ensure we won’t modify user-specified arrays. 


---