You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@yunikorn.apache.org by GitBox <gi...@apache.org> on 2020/06/02 22:21:45 UTC
[GitHub] [incubator-yunikorn-k8shim] codecov-commenter commented on pull request #132: [YUNIKORN-200] K8shim reports resource quota based on namespace annotations
codecov-commenter commented on pull request #132:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/132#issuecomment-637839018
# [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/132?src=pr&el=h1) Report
> Merging [#132](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/132?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/commit/c4730e3996d6196e8719f284686977ce7f0fcf08&el=desc) will **increase** coverage by `0.17%`.
> The diff coverage is `64.44%`.
[](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/132?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #132 +/- ##
==========================================
+ Coverage 52.78% 52.96% +0.17%
==========================================
Files 32 32
Lines 2980 3023 +43
==========================================
+ Hits 1573 1601 +28
- Misses 1347 1361 +14
- Partials 60 61 +1
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/132?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pkg/cache/context.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/132/diff?src=pr&el=tree#diff-cGtnL2NhY2hlL2NvbnRleHQuZ28=) | `21.55% <6.25%> (-0.74%)` | :arrow_down: |
| [pkg/appmgmt/general/general.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/132/diff?src=pr&el=tree#diff-cGtnL2FwcG1nbXQvZ2VuZXJhbC9nZW5lcmFsLmdv) | `50.32% <50.00%> (ø)` | |
| [pkg/common/resource.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/132/diff?src=pr&el=tree#diff-cGtnL2NvbW1vbi9yZXNvdXJjZS5nbw==) | `100.00% <100.00%> (ø)` | |
| [pkg/common/utils/utils.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/132/diff?src=pr&el=tree#diff-cGtnL2NvbW1vbi91dGlscy91dGlscy5nbw==) | `15.30% <100.00%> (+7.52%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/132?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/132?src=pr&el=footer). Last update [c4730e3...0cb24a0](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/132?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org