[GitHub] [spark] Yikun commented on a change in pull request #34456: [WIP][SPARK-36061][K8S] Add support for PodGroup

[GitBox <gi...@apache.org>]

Yikun commented on a change in pull request #34456:
URL: https://github.com/apache/spark/pull/34456#discussion_r740134238



##########
File path: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/submit/KubernetesClientApplication.scala
##########
@@ -133,6 +134,17 @@ private[spark] class Client(
       .build()
     val driverPodName = resolvedDriverPod.getMetadata.getName
 
+    val preKubernetesResources = resolvedDriverSpec.preKuberenetesResources

Review comment:
       This is for the PodGroup resource creation, previously, feature step only have the ability to create the post ready resource after pod create. But we still have some case that the resource should be ready before pods.
   
   And looks like it could be a separated PR.

##########
File path: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/submit/KubernetesClientApplication.scala
##########
@@ -145,7 +157,17 @@ private[spark] class Client(
     try {
       val otherKubernetesResources = resolvedDriverSpec.driverKubernetesResources ++ Seq(configMap)
       addOwnerReference(createdDriverPod, otherKubernetesResources)
-      kubernetesClient.resourceList(otherKubernetesResources: _*).createOrReplace()
+      var commonResources = Seq.empty[HasMetadata]

Review comment:
       This is for owner reference updated for pre created resource, we can only update owner reference after pod ready, becasuse we need the pod info like pod uid




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org