[GitHub] [flink] gaborgsomogyi commented on a diff in pull request #21128: [FLINK-29710] Bump minimum supported Hadoop version to 2.10.2

[GitBox <gi...@apache.org>]

gaborgsomogyi commented on code in PR #21128:
URL: https://github.com/apache/flink/pull/21128#discussion_r1034716206


##########
flink-yarn-tests/src/test/java/org/apache/flink/yarn/YarnTestBase.java:
##########
@@ -608,10 +611,13 @@ public boolean accept(File dir, String name) {
     public static boolean verifyStringsInNamedLogFiles(
             final String[] mustHave, final ApplicationId applicationId, final String fileName) {
         final List<String> mustHaveList = Arrays.asList(mustHave);
-        final File cwd = new File("target", YARN_CONFIGURATION.get(TEST_CLUSTER_NAME_KEY));
+        final File cwd =

Review Comment:
   No idea, I'm just wondering how it worked until now. This area is just super confusing in general because sometimes `target` but sometimes `target/test/data/` is set in `YarnTestBase.java` w/o my change. At top of this locally different execution path runs than in the CI which makes the problem even harder to explain/debug.
   
   What I can imagine but can't point it out:
   * one `pom.xml` change made the test inherit different current directory
   * YARN is getting different current directory for some magical reason
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org