You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2018/08/13 22:35:23 UTC
Review Request 68331: Windows: Made `libwinio` the default option.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68331/
-----------------------------------------------------------
Review request for mesos, Akash Gupta, Benjamin Mahler, and Joseph Wu.
Bugs: MESOS-9084
https://issues.apache.org/jira/browse/MESOS-9084
Repository: mesos
Description
-------
With no options specified, Windows will now build with the
`libwinio` (native Windows Thread API eventing library) by
default (similar to POSIX defaulting to `libev` without options). To
use `libevent` (NOT recommended), it must be explicitly enabled, and
will emit an appropriate warning. Furthermore, the tests which were
previously excluded when `libevent` was enabled are now enabled on
Windows unconditionally. This serves two reasons: (1) it simplifies
the build logic and (2) by failing with `libevent` it demonstrates why
it is not recommended (and avoids giving false impressions).
Diffs
-----
3rdparty/CMakeLists.txt 629b1968775da4d128b8d36c77d75efa303b0b7c
cmake/CompilationConfigure.cmake 10cacfb99e2cff1ddd2285ae441730f61182e06d
docs/windows.md f0f12fc81ed664528cf7496cf75e1cb11eee6013
src/tests/CMakeLists.txt fed072a8a761c6b9e65b2c75f2e92facd8353f7c
Diff: https://reviews.apache.org/r/68331/diff/1/
Testing
-------
Built with and without `-DENABLE_LIBEVENT` on Windows.
Thanks,
Andrew Schwartzmeyer
Re: Review Request 68331: Windows: Made `libwinio` the default option.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68331/#review207202
-----------------------------------------------------------
PASS: Mesos patch 68331 was successfully built and tested.
Reviews applied: `['68331']`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2143/mesos-review-68331
- Mesos Reviewbot Windows
On Aug. 13, 2018, 10:35 p.m., Andrew Schwartzmeyer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68331/
> -----------------------------------------------------------
>
> (Updated Aug. 13, 2018, 10:35 p.m.)
>
>
> Review request for mesos, Akash Gupta, Benjamin Mahler, and Joseph Wu.
>
>
> Bugs: MESOS-9084
> https://issues.apache.org/jira/browse/MESOS-9084
>
>
> Repository: mesos
>
>
> Description
> -------
>
> With no options specified, Windows will now build with the
> `libwinio` (native Windows Thread API eventing library) by
> default (similar to POSIX defaulting to `libev` without options). To
> use `libevent` (NOT recommended), it must be explicitly enabled, and
> will emit an appropriate warning. Furthermore, the tests which were
> previously excluded when `libevent` was enabled are now enabled on
> Windows unconditionally. This serves two reasons: (1) it simplifies
> the build logic and (2) by failing with `libevent` it demonstrates why
> it is not recommended (and avoids giving false impressions).
>
>
> Diffs
> -----
>
> 3rdparty/CMakeLists.txt 629b1968775da4d128b8d36c77d75efa303b0b7c
> cmake/CompilationConfigure.cmake 10cacfb99e2cff1ddd2285ae441730f61182e06d
> docs/windows.md f0f12fc81ed664528cf7496cf75e1cb11eee6013
> src/tests/CMakeLists.txt fed072a8a761c6b9e65b2c75f2e92facd8353f7c
>
>
> Diff: https://reviews.apache.org/r/68331/diff/1/
>
>
> Testing
> -------
>
> Built with and without `-DENABLE_LIBEVENT` on Windows.
>
>
> Thanks,
>
> Andrew Schwartzmeyer
>
>
Re: Review Request 68331: Windows: Made `libwinio` the default option.
Posted by Akash Gupta <ak...@hotmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68331/#review207639
-----------------------------------------------------------
Ship it!
Ship It!
- Akash Gupta
On Aug. 13, 2018, 10:35 p.m., Andrew Schwartzmeyer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68331/
> -----------------------------------------------------------
>
> (Updated Aug. 13, 2018, 10:35 p.m.)
>
>
> Review request for mesos, Akash Gupta, Benjamin Mahler, and Joseph Wu.
>
>
> Bugs: MESOS-9084
> https://issues.apache.org/jira/browse/MESOS-9084
>
>
> Repository: mesos
>
>
> Description
> -------
>
> With no options specified, Windows will now build with the
> `libwinio` (native Windows Thread API eventing library) by
> default (similar to POSIX defaulting to `libev` without options). To
> use `libevent` (NOT recommended), it must be explicitly enabled, and
> will emit an appropriate warning. Furthermore, the tests which were
> previously excluded when `libevent` was enabled are now enabled on
> Windows unconditionally. This serves two reasons: (1) it simplifies
> the build logic and (2) by failing with `libevent` it demonstrates why
> it is not recommended (and avoids giving false impressions).
>
>
> Diffs
> -----
>
> 3rdparty/CMakeLists.txt 629b1968775da4d128b8d36c77d75efa303b0b7c
> cmake/CompilationConfigure.cmake 10cacfb99e2cff1ddd2285ae441730f61182e06d
> docs/windows.md f0f12fc81ed664528cf7496cf75e1cb11eee6013
> src/tests/CMakeLists.txt fed072a8a761c6b9e65b2c75f2e92facd8353f7c
>
>
> Diff: https://reviews.apache.org/r/68331/diff/1/
>
>
> Testing
> -------
>
> Built with and without `-DENABLE_LIBEVENT` on Windows.
>
>
> Thanks,
>
> Andrew Schwartzmeyer
>
>
Re: Review Request 68331: Windows: Made `libwinio` the default option.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68331/#review207229
-----------------------------------------------------------
Patch looks great!
Reviews applied: [68331]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On Aug. 13, 2018, 10:35 p.m., Andrew Schwartzmeyer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68331/
> -----------------------------------------------------------
>
> (Updated Aug. 13, 2018, 10:35 p.m.)
>
>
> Review request for mesos, Akash Gupta, Benjamin Mahler, and Joseph Wu.
>
>
> Bugs: MESOS-9084
> https://issues.apache.org/jira/browse/MESOS-9084
>
>
> Repository: mesos
>
>
> Description
> -------
>
> With no options specified, Windows will now build with the
> `libwinio` (native Windows Thread API eventing library) by
> default (similar to POSIX defaulting to `libev` without options). To
> use `libevent` (NOT recommended), it must be explicitly enabled, and
> will emit an appropriate warning. Furthermore, the tests which were
> previously excluded when `libevent` was enabled are now enabled on
> Windows unconditionally. This serves two reasons: (1) it simplifies
> the build logic and (2) by failing with `libevent` it demonstrates why
> it is not recommended (and avoids giving false impressions).
>
>
> Diffs
> -----
>
> 3rdparty/CMakeLists.txt 629b1968775da4d128b8d36c77d75efa303b0b7c
> cmake/CompilationConfigure.cmake 10cacfb99e2cff1ddd2285ae441730f61182e06d
> docs/windows.md f0f12fc81ed664528cf7496cf75e1cb11eee6013
> src/tests/CMakeLists.txt fed072a8a761c6b9e65b2c75f2e92facd8353f7c
>
>
> Diff: https://reviews.apache.org/r/68331/diff/1/
>
>
> Testing
> -------
>
> Built with and without `-DENABLE_LIBEVENT` on Windows.
>
>
> Thanks,
>
> Andrew Schwartzmeyer
>
>