You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@storm.apache.org by "Jungtaek Lim (JIRA)" <ji...@apache.org> on 2017/03/04 02:23:45 UTC
[jira] [Resolved] (STORM-2386) Fail-back Blob deletion also fails
in BlobSynchronizer.syncBlobs
[ https://issues.apache.org/jira/browse/STORM-2386?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jungtaek Lim resolved STORM-2386.
---------------------------------
Resolution: Fixed
Fix Version/s: 1.0.4
1.1.0
2.0.0
> Fail-back Blob deletion also fails in BlobSynchronizer.syncBlobs
> ----------------------------------------------------------------
>
> Key: STORM-2386
> URL: https://issues.apache.org/jira/browse/STORM-2386
> Project: Apache Storm
> Issue Type: Bug
> Components: storm-core
> Affects Versions: 2.0.0, 1.1.0, 1.0.3
> Reporter: Jungtaek Lim
> Assignee: Jungtaek Lim
> Fix For: 2.0.0, 1.1.0, 1.0.4
>
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> This is a bug introduced from STORM-2321.
> {code}
> for (String key : keySetToDownload) {
> try {
> Set<NimbusInfo> nimbusInfoSet = BlobStoreUtils.getNimbodesWithLatestSequenceNumberOfBlob(zkClient, key);
> if (BlobStoreUtils.downloadMissingBlob(conf, blobStore, key, nimbusInfoSet)) {
> BlobStoreUtils.createStateInZookeeper(conf, key, nimbusInfo);
> }
> } catch (KeyNotFoundException e) {
> LOG.debug("Detected deletion for the key {} - deleting the blob instead", key);
> // race condition with a delete, delete the blob in key instead
> blobStore.deleteBlob(key, BlobStoreUtils.getNimbusSubject());
> }
> }
> {code}
> 'keySetToDownload' are keys which exist in Zookeeper, and do not exist in local. So deleting blob in local doesn't make sense. (Seems like I was confused at that time.)
> if downloading throws KeyNotFoundException, it means that the blob is not available neither Zookeeper nor local, so just skipping would be OK.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)