You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/09/09 01:21:55 UTC
[GitHub] [incubator-superset] ktmud commented on a change in pull request #10790: refactor: merge/upgrade superset-ui packages
ktmud commented on a change in pull request #10790:
URL: https://github.com/apache/incubator-superset/pull/10790#discussion_r485280100
##########
File path: superset-frontend/package.json
##########
@@ -22,6 +22,8 @@
"prettier-check": "prettier --check '{src,stylesheets}/**/*.{css,less,sass,scss}'",
"lint-fix": "eslint --fix --ignore-path=.eslintignore --ext .js,.jsx,.ts,tsx . && npm run clean-css && npm run type",
"clean-css": "prettier --write '{src,stylesheets}/**/*.{css,less,sass,scss}'",
+ "format": "prettier --write './{src,spec,stylesheets,cypress-base}/**/*{.js,.jsx,.ts,.tsx,.css,.less,.scss,.sass}'",
+ "prettier": "npm run format",
Review comment:
Adding a shortcut command to format files with Prettier, to be consistent with `superset-ui`
##########
File path: superset-frontend/package.json
##########
@@ -149,6 +140,7 @@
"react-hot-loader": "^4.12.20",
"react-json-tree": "^0.11.2",
"react-jsonschema-form": "^1.2.0",
+ "react-loadable": "^5.5.0",
Review comment:
Previously a dependency of `@superset-ui/chart`, adding it here because it was [moved](https://github.com/apache-superset/superset-ui/pull/774) to `peerDependencies` of `@superset-ui/core`.
##########
File path: superset-frontend/package.json
##########
@@ -118,6 +108,7 @@
"dnd-core": "^2.6.0",
"dom-to-image": "^2.6.0",
"geolib": "^2.0.24",
+ "global-box": "^1.2.0",
Review comment:
A new `peerDependency` from the updated `encodable`, which is a dependency of `preset-chart-xy`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org