You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "Parkerhiphop (via GitHub)" <gi...@apache.org> on 2026/08/11 03:19:18 UTC

[PR] MINOR: Bump trunk to 4.5.0-SNAPSHOT [kafka]

Parkerhiphop opened a new pull request, #23125:
URL: https://github.com/apache/kafka/pull/23125

   As described in
   
   https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=34840886#ReleaseProcess-CutBranches
   
   This is the standard post-branch-cut bump after the 4.4 branch was created. Trunk now tracks 4.5.0-SNAPSHOT.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] MINOR: Bump trunk to 4.5.0-SNAPSHOT [kafka]

Posted by "Parkerhiphop (via GitHub)" <gi...@apache.org>.
Parkerhiphop commented on code in PR #23125:
URL: https://github.com/apache/kafka/pull/23125#discussion_r3838416793


##########
server-common/src/test/java/org/apache/kafka/server/common/MetadataVersionTest.java:
##########
@@ -205,10 +207,10 @@ public void testRegisterBrokerRecordVersion(MetadataVersion metadataVersion) {
     }
 
     @Test
-    public void assertLatestProductionIsLessThanLatest() {
-        assertTrue(LATEST_PRODUCTION.ordinal() < MetadataVersion.latestTesting().ordinal(),
+    public void assertLatestProductionIsNotAfterLatestTesting() {

Review Comment:
   I opened a follow-up PR for it: https://github.com/apache/kafka/pull/23244



##########
server-common/src/test/java/org/apache/kafka/server/common/MetadataVersionTest.java:
##########
@@ -205,10 +207,10 @@ public void testRegisterBrokerRecordVersion(MetadataVersion metadataVersion) {
     }
 
     @Test
-    public void assertLatestProductionIsLessThanLatest() {
-        assertTrue(LATEST_PRODUCTION.ordinal() < MetadataVersion.latestTesting().ordinal(),
+    public void assertLatestProductionIsNotAfterLatestTesting() {

Review Comment:
   Got it. I opened a follow-up PR for it: https://github.com/apache/kafka/pull/23244



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] MINOR: Bump trunk to 4.5.0-SNAPSHOT [kafka]

Posted by "Parkerhiphop (via GitHub)" <gi...@apache.org>.
Parkerhiphop commented on code in PR #23125:
URL: https://github.com/apache/kafka/pull/23125#discussion_r3755114934


##########
.github/workflows/ci.yml:
##########
@@ -28,7 +28,7 @@ on:
     types: [ opened, synchronize, ready_for_review, reopened ]
     branches:
       - 'trunk'
-      - '4.3'
+      - '4.4'

Review Comment:
   Thanks for reviewing!
   
   Yes. I checked the current supported releases and recent branch activity, and both 4.3 and 4.2 are still active maintenance branches.
   
   I’ll include them in both push and pull_request so this workflow also runs for PRs and pushes targeting those branches.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] MINOR: Bump trunk to 4.5.0-SNAPSHOT [kafka]

Posted by "Parkerhiphop (via GitHub)" <gi...@apache.org>.
Parkerhiphop commented on code in PR #23125:
URL: https://github.com/apache/kafka/pull/23125#discussion_r3842127899


##########
metadata/src/test/java/org/apache/kafka/metadata/storage/FormatterTest.java:
##########
@@ -299,6 +300,7 @@ public void testFormatWithOlderReleaseVersion() throws Exception {
 
     @Test
     public void testFormatWithUnstableReleaseVersionFailsWithoutEnableUnstable() throws Exception {
+        assumeFalse(MetadataVersion.latestTesting().isProduction());

Review Comment:
   I opened a minor for it: https://github.com/apache/kafka/pull/23254.
   
   Sorry for missing this one. 🥲



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] MINOR: Bump trunk to 4.5.0-SNAPSHOT [kafka]

Posted by "Parkerhiphop (via GitHub)" <gi...@apache.org>.
Parkerhiphop commented on PR #23125:
URL: https://github.com/apache/kafka/pull/23125#issuecomment-5254961078

   > I think we need to update `https://github.com/apache/kafka/blob/trunk/server-common/src/main/java/org/apache/kafka/server/common/MetadataVersion.java` too because `LATEST_PRODUCTION` should be `IBP_4_4_IV2` I think.
   
   Thanks for reviewing and pointing out.
   
   I updated `LATEST_PRODUCTION` to `IBP_4_4_IV2` and synced `LATEST_STABLE_METADATA_VERSION` in kafkatest.
   
   Since `IBP_4_4_IV2` was previously the latest enum value, I also added `IBP_4_5_IV0` as the new unstable/testing metadata version for trunk and moved the unstable-version boundary comment accordingly. MetadataVersionTest passes locally.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] MINOR: Bump trunk to 4.5.0-SNAPSHOT [kafka]

Posted by "chia7712 (via GitHub)" <gi...@apache.org>.
chia7712 commented on code in PR #23125:
URL: https://github.com/apache/kafka/pull/23125#discussion_r3755049780


##########
.github/workflows/ci.yml:
##########
@@ -28,7 +28,7 @@ on:
     types: [ opened, synchronize, ready_for_review, reopened ]
     branches:
       - 'trunk'
-      - '4.3'
+      - '4.4'

Review Comment:
   I'm wondering whether the active branches `4.3` and `4.2` should be included



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] MINOR: Bump trunk to 4.5.0-SNAPSHOT [kafka]

Posted by "AndrewJSchofield (via GitHub)" <gi...@apache.org>.
AndrewJSchofield commented on PR #23125:
URL: https://github.com/apache/kafka/pull/23125#issuecomment-5252820269

   I think we need to update `https://github.com/apache/kafka/blob/trunk/server-common/src/main/java/org/apache/kafka/server/common/MetadataVersion.java` too because `LATEST_PRODUCTION` should be `IBP_4_4_IV2` I think.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] MINOR: Bump trunk to 4.5.0-SNAPSHOT [kafka]

Posted by "chia7712 (via GitHub)" <gi...@apache.org>.
chia7712 commented on code in PR #23125:
URL: https://github.com/apache/kafka/pull/23125#discussion_r3841933547


##########
metadata/src/test/java/org/apache/kafka/metadata/storage/FormatterTest.java:
##########
@@ -299,6 +300,7 @@ public void testFormatWithOlderReleaseVersion() throws Exception {
 
     @Test
     public void testFormatWithUnstableReleaseVersionFailsWithoutEnableUnstable() throws Exception {
+        assumeFalse(MetadataVersion.latestTesting().isProduction());

Review Comment:
   I guess we were all drunk-reviewing #23244 - this should be reverted too...
   
   @Parkerhiphop would you mind creating another follow-up? 



##########
metadata/src/test/java/org/apache/kafka/metadata/storage/FormatterTest.java:
##########
@@ -309,6 +311,7 @@ public void testFormatWithUnstableReleaseVersionFailsWithoutEnableUnstable() thr
 
     @Test
     public void testFormatWithUnstableReleaseVersion() throws Exception {
+        assumeFalse(MetadataVersion.latestTesting().isProduction());

Review Comment:
   ditto



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] MINOR: Bump trunk to 4.5.0-SNAPSHOT [kafka]

Posted by "Parkerhiphop (via GitHub)" <gi...@apache.org>.
Parkerhiphop commented on code in PR #23125:
URL: https://github.com/apache/kafka/pull/23125#discussion_r3755114934


##########
.github/workflows/ci.yml:
##########
@@ -28,7 +28,7 @@ on:
     types: [ opened, synchronize, ready_for_review, reopened ]
     branches:
       - 'trunk'
-      - '4.3'
+      - '4.4'

Review Comment:
   Yes. I checked the current supported releases and recent branch activity, and both 4.3 and 4.2 are still active maintenance branches.
   
   I’ll include them in both push and pull_request so this workflow also runs for PRs and pushes targeting those branches.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] MINOR: Bump trunk to 4.5.0-SNAPSHOT [kafka]

Posted by "AndrewJSchofield (via GitHub)" <gi...@apache.org>.
AndrewJSchofield commented on code in PR #23125:
URL: https://github.com/apache/kafka/pull/23125#discussion_r3760692679


##########
server-common/src/main/java/org/apache/kafka/server/common/MetadataVersion.java:
##########
@@ -124,21 +124,24 @@ public enum MetadataVersion {
     // BrokerRegistrationChangeRecord and RegisterBrokerRecord are updated
     IBP_4_3_IV0(30, "4.3", "IV0", true),
 
-    //
-    // NOTE: MetadataVersions after this point are unstable and may be changed.
-    // If users attempt to use an unstable MetadataVersion, they will get an error unless
-    // they have set the configuration unstable.feature.versions.enable=true.
-    // Please move this comment when updating the LATEST_PRODUCTION constant.
-    //
-
     // IBP_4_4_IV0 enables dead-letter queue support for share groups (KIP-1191).
     IBP_4_4_IV0(31, "4.4", "IV0", false),
 
     // Add support for CIDR-based ACL host patterns (KIP-1276).
     IBP_4_4_IV1(32, "4.4", "IV1", true),
 
     // Add support for controller unregistration (KIP-1312).
-    IBP_4_4_IV2(33, "4.4", "IV2", true);
+    IBP_4_4_IV2(33, "4.4", "IV2", true),
+
+    //
+    // NOTE: MetadataVersions after this point are unstable and may be changed.
+    // If users attempt to use an unstable MetadataVersion, they will get an error unless
+    // they have set the configuration unstable.feature.versions.enable=true.
+    // Please move this comment when updating the LATEST_PRODUCTION constant.
+    //
+
+    // New version for the Kafka 4.5.0 release.
+    IBP_4_5_IV0(34, "4.5", "IV0", false);

Review Comment:
   I don't think you need to add this one yet, just moving the comment tells the next MV author where to insert their new MV.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] MINOR: Bump trunk to 4.5.0-SNAPSHOT [kafka]

Posted by "Parkerhiphop (via GitHub)" <gi...@apache.org>.
Parkerhiphop commented on code in PR #23125:
URL: https://github.com/apache/kafka/pull/23125#discussion_r3767835625


##########
server-common/src/main/java/org/apache/kafka/server/common/MetadataVersion.java:
##########
@@ -124,21 +124,24 @@ public enum MetadataVersion {
     // BrokerRegistrationChangeRecord and RegisterBrokerRecord are updated
     IBP_4_3_IV0(30, "4.3", "IV0", true),
 
-    //
-    // NOTE: MetadataVersions after this point are unstable and may be changed.
-    // If users attempt to use an unstable MetadataVersion, they will get an error unless
-    // they have set the configuration unstable.feature.versions.enable=true.
-    // Please move this comment when updating the LATEST_PRODUCTION constant.
-    //
-
     // IBP_4_4_IV0 enables dead-letter queue support for share groups (KIP-1191).
     IBP_4_4_IV0(31, "4.4", "IV0", false),
 
     // Add support for CIDR-based ACL host patterns (KIP-1276).
     IBP_4_4_IV1(32, "4.4", "IV1", true),
 
     // Add support for controller unregistration (KIP-1312).
-    IBP_4_4_IV2(33, "4.4", "IV2", true);
+    IBP_4_4_IV2(33, "4.4", "IV2", true),
+
+    //
+    // NOTE: MetadataVersions after this point are unstable and may be changed.
+    // If users attempt to use an unstable MetadataVersion, they will get an error unless
+    // they have set the configuration unstable.feature.versions.enable=true.
+    // Please move this comment when updating the LATEST_PRODUCTION constant.
+    //
+
+    // New version for the Kafka 4.5.0 release.
+    IBP_4_5_IV0(34, "4.5", "IV0", false);

Review Comment:
   Thanks, that makes sense. I originally added `IBP_4_5_IV0` to keep the existing `latestTesting() > LATEST_PRODUCTION` invariant used by some tests. I removed it now and kept the unstable-version boundary comment after `IBP_4_4_IV2` instead.
   
   I also updated the affected tests to handle the temporary state where `latestTesting()` can equal `LATEST_PRODUCTION`.
   `MetadataVersionTest` still verifies that `latestTesting` is unstable when it is newer than `LATEST_PRODUCTION`, and `FormatterTest` now skips unstable-release-version cases when no unstable MV exists. I also updated the expected share.version default to `SV_2` since `LATEST_PRODUCTION` is now 4.4-IV2.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] MINOR: Bump trunk to 4.5.0-SNAPSHOT [kafka]

Posted by "chia7712 (via GitHub)" <gi...@apache.org>.
chia7712 commented on code in PR #23125:
URL: https://github.com/apache/kafka/pull/23125#discussion_r3838319636


##########
server-common/src/test/java/org/apache/kafka/server/common/MetadataVersionTest.java:
##########
@@ -205,10 +207,10 @@ public void testRegisterBrokerRecordVersion(MetadataVersion metadataVersion) {
     }
 
     @Test
-    public void assertLatestProductionIsLessThanLatest() {
-        assertTrue(LATEST_PRODUCTION.ordinal() < MetadataVersion.latestTesting().ordinal(),
+    public void assertLatestProductionIsNotAfterLatestTesting() {

Review Comment:
   Sorry for my oversight. We should not change those tests at all. The correct way is to add `IBP_4_5_IV0`
   
   Would you mind opening a follow-up to address this?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] MINOR: Bump trunk to 4.5.0-SNAPSHOT [kafka]

Posted by "AndrewJSchofield (via GitHub)" <gi...@apache.org>.
AndrewJSchofield merged PR #23125:
URL: https://github.com/apache/kafka/pull/23125


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org