[GitHub] [avro] clesaec commented on pull request #1742: AVRO-3527: Optimize GenericData.hashCode

[GitBox <gi...@apache.org>]

clesaec commented on PR #1742:
URL: https://github.com/apache/avro/pull/1742#issuecomment-1313283142

   Indeed, AtomicInteger, atomicity is may be too much, and an array of size one (int[]) may be to blurry, i will create a specific private class for that.
   For optimization with calculating once each power of 31; it means transform
   ```
   31*(31*(31*(31*hash(f1) + hash(f2)) + hash(f3)) + hash(f4))
   31*(31*hash(f'1) + hash(f'2)) + hash(f'3)
   ```
   into 
   `31*(31*(31*(31*hash(f1) + hash(f2)) + hash(f3) + hash(f'1)) + hash(f4) + hash(f'2)) + hash(f'3)`
   But, as one field, as f2, can also be itself an Array of record containing itself fields ... , it will lead to too complex code for saving at most 10 multiplications.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org