Patches submitted by the GP and CLA's -> Re: SQL Extension, how to close just one query?

[John Gentilin <ge...@eyecatching.com>]

Moraine,

Now that looks like an adventure.... Great work.
I have no problem commiting this the code to the distribution
since it can't be anymore broken that what is there now.

It would be nice if someone from the core DTM crew gave the
code a once over...

Now for the ugly news, the Apache group has hired lawyer's and 
they are getting serious about official committers and having 
their signed CLA's. See http://www.apache.org/licenses/#clas 

I was curious about how this affected patches that was submitted by
the general public to a committer and the word is everyone has to 
sign a CLA. So before I can check in your code, I need you to 
to download and fax in the form... I have included the message 
thread below that I had with some of the core members of the team.

Regards
John G

>>>>>>??>>>>>>>>>>>>>>>> CLA MESSAGE THREAD <<<<<<<<<<<<<<<<<<<<<<<<<<<<<
scott_boag@us.ibm.com wrote:

> Ugh.  Contributer License Agreement.  Yech.
>
> -scott
>
> ----- Forwarded by Scott Boag/Cambridge/IBM on 08/20/2004 02:37 PM -----
>
> Sarah McNamara/Toronto/IBM@IBMCA 08/20/2004 02:08 PM
>
> To
> Scott Boag/Cambridge/IBM@LOTUS
> cc
>
> Subject
> Fw: Apache position on accepting contributions from the general public
>
> In order to accept an enhancement or bug fix all committers should be verifying that a Contributor License Agreement is on file for the contributor, if not, then the committers should be pointing the contributors to the legal page on Apache where they can find the info on CLAs.   http://www.apache.org/licenses/#clas
>  
> Sarah McNamara
> ----- Forwarded by Sarah McNamara/Toronto/IBM on 08/20/2004 01:53 PM -----
>
> Scott Boag/Cambridge/IBM@LOTUS 08/20/2004 01:28 PM
>
> To
> Sarah McNamara/Toronto/IBM@IBMCA
> cc
>
> Subject
> Fw: Apache position on accepting contributions from the general public
>
> Sarah, do you know the latest answer to John's question about submitted code?  I would think the answer is "don't worry about it unless you think there is significant IP" or some such.  But I haven't really kept up on the latest rules.
>
> -scott
>
> ----- Forwarded by Scott Boag/Cambridge/IBM on 08/20/2004 01:25 PM -----
>
> Subject
> Apache position on accepting contributions from the general public
>
> Scott,
>
> Its been a while, hope things are going well.
>
> Recently I have received a few bug patches / enhancements. Most were
> the < 5 line changes, some are larger. I wanted to check to see if someone
> submitted a patch to me (non committer) and I integrated it into the release,
> do they need to sign a committer agreement ?? I sent an email to apache@apache.org
> a day or so ago but it seems to have fallen on deaf ears. As an example, see the
> thread
> "Re: SQL Extension, how to close just one query?"
> http://marc.theaimsgroup.com/?l=xalan-dev&m=109292106807768&w=2
>
> Also if you get a moment, look at the code. The SQL extension returns
> a DTM but the object assigned to the variable is an Iterator and we are
> having trouble identifying the original DTM. See message
> http://marc.theaimsgroup.com/?l=xalan-dev&m=109285434815559&w=2
>
> -JG
>
>>>>>>>>>>>>>>>>>>>>>>>>>>> END THREAD <<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<

Moraine Didier wrote:

> [Trying to join the thread]
> 
> Hello, 
> 
> We have the same problem and this is what we tried today :
> 
> public void close( Object sqldoc ) throws SQLException {
>     if (DEBUG)
>         System.out.println("Entering XConnection.close(" + sqldoc + ")");
> 
>     if (sqldoc instanceof DTMNodeIterator) {
>            
>         DTMNodeIterator dtmIter = (DTMNodeIterator) sqldoc;
>             
>         if (dtmIter.getDTMIterator() instanceof XNodeSet) {
>                 
>             XNodeSet xNS = (XNodeSet) dtmIter.getDTMIterator();
> 
>             if (xNS.getContainedIter() instanceof OneStepIterator) {
>                     
>                 OneStepIterator iter = (OneStepIterator)
> xNS.getContainedIter();
>                 DTMManager dtmMgr = (DTMManager) iter.getDTMManager();
>                     
>                 //Finally :-)
>                 if (dtmMgr.getDTM(xNS.nextNode()) instanceof SQLDocument) {
>                         
>                     sqldoc = (SQLDocument) dtmMgr.getDTM(xNS.nextNode());
> 
>                     int size = m_OpenSQLDocuments.size();
> 
>                     for (int x = 0; x < size; x++) {
>                         SQLDocument d = (SQLDocument)
> m_OpenSQLDocuments.elementAt(x);
>                         if (d == sqldoc) {
>                             d.close();
>                             m_OpenSQLDocuments.removeElementAt(x);
>                         }
>                     }
>                 } else {
>                     throw new RuntimeException(
>                             "Class cast exception XConnection.close(Object)
> !");
>                 }
>             } else {
>                 throw new RuntimeException(
>                         "Class cast exception XConnection.close(Object) !");
>             }
>         } else {
>             throw new RuntimeException(
>                     "Class cast exception XConnection.close(Object) !");
>         }
>     }
> }
> 
> We are now able to close a single SQLDocument and put back the connection in
> the pool
> with :
> 
> <xsl:variable name="Qy" select="sql:query($DbCon, $SQL)"/>
> ...
> <xsl:value-of select="sql:close($DbCon, $Qy)"/>
> 
> Regards,
> 





---------------------------------------------------------------------
To unsubscribe, e-mail: xalan-dev-unsubscribe@xml.apache.org
For additional commands, e-mail: xalan-dev-help@xml.apache.org