You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by "stefanvodita (via GitHub)" <gi...@apache.org> on 2025/03/02 23:07:04 UTC
[I] Create a bot to check if there is a CHANGES entry for new PRs [lucene]
stefanvodita opened a new issue, #13898:
URL: https://github.com/apache/lucene/issues/13898
### Description
We always have to remind ourselves and others to add a CHANGES entry. We can probably write a GitHub action to check for changes to that file on every new PR and leave a comment warning the author if that's missing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
Re: [I] Create a bot to check if there is a CHANGES entry for new PRs [lucene]
Posted by "prudhvigodithi (via GitHub)" <gi...@apache.org>.
prudhvigodithi commented on issue #13898:
URL: https://github.com/apache/lucene/issues/13898#issuecomment-2408659537
Here is the sample PR with change-log verifier action added https://github.com/prudhvigodithi/lucene/pull/1, we can add the same workflow to lucene repo. But I see the error `dangoslen/changelog-enforcer@v3 is not allowed to be used in apache/lucene. `.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
Re: [I] Create a bot to check if there is a CHANGES entry for new PRs [lucene]
Posted by "pseudo-nymous (via GitHub)" <gi...@apache.org>.
pseudo-nymous commented on issue #13898:
URL: https://github.com/apache/lucene/issues/13898#issuecomment-2726787800
Thanks @stefanvodita! I will take a look at the fix and propose changes accordingly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
Re: [I] Create a bot to check if there is a CHANGES entry for new PRs [lucene]
Posted by "stefanvodita (via GitHub)" <gi...@apache.org>.
stefanvodita commented on issue #13898:
URL: https://github.com/apache/lucene/issues/13898#issuecomment-2875906960
I thought about it some more. The way we envisioned PR authors choosing not to run the verifier is by adding the [`skip-changelog-check` label](https://github.com/apache/lucene/labels/skip-changelog-check). I should have mentioned this in the email I sent to the dev list.
Here is what I'd like to do next if it seems good to you as well.
1. Update the bot's comment to tell people they can use the label to skip the check on their PR. If they don't add the label, the bot will continue reminding us as the PR gets updated. If they do add the label, the bot will stop.
2. Eventually make the bot smarter like you are suggesting, so that it doesn't run on PRs that we know don't need a CHANGES entry. Maybe we would do this by unifying with the [module lebeler](https://github.com/apache/lucene/blob/main/.github/labeler.yml), which already looks at which files were touched.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
Re: [I] Create a bot to check if there is a CHANGES entry for new PRs [lucene]
Posted by "jainankitk (via GitHub)" <gi...@apache.org>.
jainankitk commented on issue #13898:
URL: https://github.com/apache/lucene/issues/13898#issuecomment-2864277665
> > dangoslen/changelog-enforcer@v3 is not allowed to be used in apache/lucene
>
> Apache projects are not allowed to use arbitrary actions for security reasons, please take a look at: https://infra.apache.org/github-actions-policy.html#External%5C%20actions
Okay, I was just curious about the resource usage policy and noticed some inconsistent information (calendar week should have more allowed runners):
* The average number of minutes a project uses per calendar week MUST NOT exceed the equivalent of 25 full-time runners (250,000 minutes, or 4,200 hours).
* The average number of minutes a project uses in any consecutive five-day period MUST NOT exceed the equivalent of 30 full-time runners (216,000 minutes, or 3,600 hours).
Wondering if we can fix this documentation inconsistency
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
Re: [I] Create a bot to check if there is a CHANGES entry for new PRs [lucene]
Posted by "stefanvodita (via GitHub)" <gi...@apache.org>.
stefanvodita commented on issue #13898:
URL: https://github.com/apache/lucene/issues/13898#issuecomment-2733970610
Just to clarify - the restriction @dweiss mentioned applies to the `changelog-enforcer` action, but not to the `checkout` action we are using.
@pseudo-nymous - I'm seeing new failures now, e.g. a [fatal](https://github.com/apache/lucene/actions/runs/13876712827/job/388299374080).
It's frustrating that the tests we perform on our forks aren't reflective of the behaviour we see in the main repo.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
Re: [I] Create a bot to check if there is a CHANGES entry for new PRs [lucene]
Posted by "pseudo-nymous (via GitHub)" <gi...@apache.org>.
pseudo-nymous commented on issue #13898:
URL: https://github.com/apache/lucene/issues/13898#issuecomment-2735279420
@stefanvodita I have added a fix for it. Please take a look. https://github.com/apache/lucene/pull/14369
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
Re: [I] Create a bot to check if there is a CHANGES entry for new PRs [lucene]
Posted by "stefanvodita (via GitHub)" <gi...@apache.org>.
stefanvodita commented on issue #13898:
URL: https://github.com/apache/lucene/issues/13898#issuecomment-2721556890
@pseudo-nymous, I've attempted a fix in #14355.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
Re: [I] Create a bot to check if there is a CHANGES entry for new PRs [lucene]
Posted by "stefanvodita (via GitHub)" <gi...@apache.org>.
stefanvodita commented on issue #13898:
URL: https://github.com/apache/lucene/issues/13898#issuecomment-2875933174
#14656 is what I was suggesting as an immediate step. I wonder if all contributors have permissions to add labels to their PRs though.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
Re: [I] Create a bot to check if there is a CHANGES entry for new PRs [lucene]
Posted by "stefanvodita (via GitHub)" <gi...@apache.org>.
stefanvodita commented on issue #13898:
URL: https://github.com/apache/lucene/issues/13898#issuecomment-2692956304
I was looking at the workflow that @pseudo-nymous wrote. The [logs](https://github.com/apache/lucene/actions/runs/13597403773/job/38017259510) for #14276 say there is no CHANGES entry. We'll need to fix that. I've also added the PR number to the output (#14324), since I couldn't see it anywhere.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
Re: [I] Create a bot to check if there is a CHANGES entry for new PRs [lucene]
Posted by "stefanvodita (via GitHub)" <gi...@apache.org>.
stefanvodita commented on issue #13898:
URL: https://github.com/apache/lucene/issues/13898#issuecomment-2875620327
The bot has processed one PR (#14653) and I already see something I'm not sure I like - it will post a comment every time we push to the branch and are missing a CHANGES entry. I can see arguments on both sides, but I think I would prefer a single comment per PR. We could probably do that by adding a label to the PR after the first comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
Re: [I] Create a bot to check if there is a CHANGES entry for new PRs [lucene]
Posted by "dweiss (via GitHub)" <gi...@apache.org>.
dweiss commented on issue #13898:
URL: https://github.com/apache/lucene/issues/13898#issuecomment-2875734587
One would be probably enough. I'm also not sure we should require all changes in changes.txt. The one in 14653 doesn't seem to be that important (it applies to build infrastructure, nobody looking at changes.txt will ever care about it?).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
Re: [I] Create a bot to check if there is a CHANGES entry for new PRs [lucene]
Posted by "stefanvodita (via GitHub)" <gi...@apache.org>.
stefanvodita commented on issue #13898:
URL: https://github.com/apache/lucene/issues/13898#issuecomment-2848685578
I created a new GitHub account with its own Lucene fork and opened a [PR](https://github.com/stefanvodita/lucene/pull/9) against my old account to replicate the behaviour we were seeing. This worked well and I think I've been able to fix a few of the issues in #14606. We'll monitor after the fix is merged. For now, the workflow is still only logging and not actually performing write operations on PRs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
Re: [I] Create a bot to check if there is a CHANGES entry for new PRs [lucene]
Posted by "javanna (via GitHub)" <gi...@apache.org>.
javanna commented on issue #13898:
URL: https://github.com/apache/lucene/issues/13898#issuecomment-2410385807
Yes to this! It would be great to combine this with setting the milestone :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
Re: [I] Create a bot to check if there is a CHANGES entry for new PRs [lucene]
Posted by "rmuir (via GitHub)" <gi...@apache.org>.
rmuir commented on issue #13898:
URL: https://github.com/apache/lucene/issues/13898#issuecomment-2875814389
Maybe we could look for a change to `*.java` as a heuristic?
This would prevent noise for stuff like build system updates, doc updates, dependabot updates, python dev scripts, etc?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
Re: [I] Create a bot to check if there is a CHANGES entry for new PRs [lucene]
Posted by "stefanvodita (via GitHub)" <gi...@apache.org>.
stefanvodita closed issue #13898: Create a bot to check if there is a CHANGES entry for new PRs
URL: https://github.com/apache/lucene/issues/13898
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
Re: [I] Create a bot to check if there is a CHANGES entry for new PRs [lucene]
Posted by "pseudo-nymous (via GitHub)" <gi...@apache.org>.
pseudo-nymous commented on issue #13898:
URL: https://github.com/apache/lucene/issues/13898#issuecomment-2888494102
Github does not allow adding labels by non owners of a repo. Ref: [link](https://github.com/isaacs/github/issues/875)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
Re: [I] Create a bot to check if there is a CHANGES entry for new PRs [lucene]
Posted by "stefanvodita (via GitHub)" <gi...@apache.org>.
stefanvodita commented on issue #13898:
URL: https://github.com/apache/lucene/issues/13898#issuecomment-2870276813
I've been monitoring the jobs after the most recent batch of fixes and I'm happy with the results. The only change that the bot got wrong was #14638 ([logs](https://github.com/apache/lucene/actions/runs/14941689255/job/41979703606)), which moves around a changelog entry from 11.0.0 to 10.3.0. The bot would still assign it milestone 11.0.0, but I think that's not a serious mistake and I'm willing to take a progress-not-perfection approach here. I opened #14644 to start assigning milestones automatically ([test](https://github.com/stefanvodita/lucene/actions/runs/14960617144/job/42022012969?pr=9)) and to post a comment on PRs that don't have a changelog entry ([test](https://github.com/stefanvodita/lucene/actions/runs/14960628233/job/42022036265?pr=9)). If there aren't objections, I will send an announcement to the dev list ahead of pushing this and enabling the bot.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
Re: [I] Create a bot to check if there is a CHANGES entry for new PRs [lucene]
Posted by "stefanvodita (via GitHub)" <gi...@apache.org>.
stefanvodita closed issue #13898: Create a bot to check if there is a CHANGES entry for new PRs
URL: https://github.com/apache/lucene/issues/13898
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
Re: [I] Create a bot to check if there is a CHANGES entry for new PRs [lucene]
Posted by "stefanvodita (via GitHub)" <gi...@apache.org>.
stefanvodita commented on issue #13898:
URL: https://github.com/apache/lucene/issues/13898#issuecomment-2411705472
@prudhvigodithi - I opened #13898 inspired by your PR, tested it on my fork, and it's working correctly.
@javanna - I like that idea! Maybe we can do that as a follow-up.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
Re: [I] Create a bot to check if there is a CHANGES entry for new PRs [lucene]
Posted by "stefanvodita (via GitHub)" <gi...@apache.org>.
stefanvodita commented on issue #13898:
URL: https://github.com/apache/lucene/issues/13898#issuecomment-2863442745
I pushed a few more fixes in #14628. We have our first successful instance of the changelog being validated and a milestone extracted from it ([logs](https://github.com/apache/lucene/actions/runs/14906069230/job/41868625305))!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
Re: [I] Create a bot to check if there is a CHANGES entry for new PRs [lucene]
Posted by "pseudo-nymous (via GitHub)" <gi...@apache.org>.
pseudo-nymous commented on issue #13898:
URL: https://github.com/apache/lucene/issues/13898#issuecomment-2693761988
Thanks for updating the script with PR number. I'll root cause and fix the issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
Re: [I] Create a bot to check if there is a CHANGES entry for new PRs [lucene]
Posted by "dweiss (via GitHub)" <gi...@apache.org>.
dweiss commented on issue #13898:
URL: https://github.com/apache/lucene/issues/13898#issuecomment-2726850239
> dangoslen/changelog-enforcer@v3 is not allowed to be used in apache/lucene
Apache projects are not allowed to use arbitrary actions for security reasons, please take a look at:
https://infra.apache.org/github-actions-policy.html#External%5C%20actions
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org