[GitHub] [flink] godfreyhe commented on a change in pull request #14562: [FLINK-20738][table-planner-blink] Separate the implementation of batch group aggregate nodes

[GitBox <gi...@apache.org>]

godfreyhe commented on a change in pull request #14562:
URL: https://github.com/apache/flink/pull/14562#discussion_r552627854



##########
File path: flink-table/flink-table-planner-blink/src/main/java/org/apache/flink/table/planner/plan/nodes/exec/utils/ExecNodeUtil.java
##########
@@ -35,6 +38,11 @@
 /** An Utility class that helps translating {@link ExecNode} to {@link Transformation}. */
 public class ExecNodeUtil {
 
+    /** Return bytes size for given option in {@link TableConfig}. */
+    public static long getMemorySize(TableConfig tableConfig, ConfigOption<String> option) {
+        return MemorySize.parse(tableConfig.getConfiguration().getString(option)).getBytes();

Review comment:
       It will broken current API, because the compile error will occur when user's code is `configuration.set(
         ExecutionConfigOptions.TABLE_EXEC_RESOURCE_HASH_AGG_MEMORY, "128 mb")`




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org