[GitHub] [spark] sandeep-katta commented on a change in pull request #24837: [SPARK-27917][SQL][BACKPORT-2.3] canonical form of CaseWhen object is incorrect

[GitBox <gi...@apache.org>]

sandeep-katta commented on a change in pull request #24837: [SPARK-27917][SQL][BACKPORT-2.3] canonical form of CaseWhen object is incorrect
URL: https://github.com/apache/spark/pull/24837#discussion_r292299968
 
 

 ##########
 File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/trees/TreeNode.scala
 ##########
 @@ -199,6 +199,21 @@ abstract class TreeNode[BaseType <: TreeNode[BaseType]] extends Product {
     var changed = false
     val remainingNewChildren = newChildren.toBuffer
     val remainingOldChildren = children.toBuffer
+    def mapChild(child: Any): AnyRef = {
+      child match {
+        case arg: TreeNode[_] if containsChild(arg) =>
+          val newChild = remainingNewChildren.remove(0)
+          val oldChild = remainingOldChildren.remove(0)
+          if (newChild fastEquals oldChild) {
+            oldChild
+          } else {
+            changed = true
+            newChild
+          }
+        case nonChild: AnyRef => nonChild
+        case null => null
+      }
+    }
 
 Review comment:
   okay no problem

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org