You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@grails.apache.org by "jamesfredley (via GitHub)" <gi...@apache.org> on 2026/06/26 03:16:07 UTC
[PR] Use config-driven Grails version docs [grails-core]
jamesfredley opened a new pull request, #15769:
URL: https://github.com/apache/grails-core/pull/15769
## Summary
- derive a `grailsMajorVersion` docs attribute from `projectVersion`
- let YAML guide TOC titles substitute configured doc properties
- replace stale current-version Grails 7/8 wording with config-driven or version-neutral text
## Verification
- `./gradlew :grails-doc:publishGuide -x aggregateGroovydoc`
- `./gradlew :grails-data-hibernate7-docs:asciidoctor`
- `./gradlew aggregateViolations :grails-test-report:check --continue` attempted twice, but both runs exceeded the 10-minute shell cap while still running tests
- `./gradlew aggregateViolations :grails-test-report:check --continue` generated aggregate violation reports before timing out: Checkstyle, CodeNarc, PMD, and SpotBugs all reported no violations
- `./gradlew :grails-doc:publishGuide -x aggregateGroovydoc` rerun after the timed-out full validation
- `./gradlew :grails-data-hibernate7-docs:asciidoctor` rerun after the timed-out full validation
- `./gradlew.bat check` from `build-logic`
- `git diff --check`
Assisted-by: Hephaestus:gpt-5.5
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@grails.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Use config-driven Grails version docs [grails-core]
Posted by "testlens-app[bot] (via GitHub)" <gi...@apache.org>.
testlens-app[bot] commented on PR #15769:
URL: https://github.com/apache/grails-core/pull/15769#issuecomment-4806381235
## ✅ All tests passed ✅
🏷️ Commit: 650db0afbdeb2addd7356355fad4bd0613d521de
▶️ Tests: 40324 executed
⚪️ Checks: 45/45 completed
---
_Learn more about TestLens at [testlens.app](https://testlens.app)._
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@grails.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Use config-driven Grails version docs [grails-core]
Posted by "testlens-app[bot] (via GitHub)" <gi...@apache.org>.
testlens-app[bot] commented on PR #15769:
URL: https://github.com/apache/grails-core/pull/15769#issuecomment-4809195354
## ✅ All tests passed ✅
🏷️ Commit: 6bd3370f798db62bd77a5e5258828ec9c31da24a
▶️ Tests: 36166 executed
⚪️ Checks: 44/44 completed
---
_Learn more about TestLens at [testlens.app](https://testlens.app)._
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@grails.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Use config-driven Grails version docs [grails-core]
Posted by "jamesfredley (via GitHub)" <gi...@apache.org>.
jamesfredley merged PR #15769:
URL: https://github.com/apache/grails-core/pull/15769
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@grails.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Use config-driven Grails version docs [grails-core]
Posted by "Copilot (via GitHub)" <gi...@apache.org>.
Copilot commented on code in PR #15769:
URL: https://github.com/apache/grails-core/pull/15769#discussion_r3478934704
##########
settings.gradle:
##########
@@ -205,7 +205,7 @@ include(
'grails-datamapping-core-test',
// RX projects
- // until this can be finished ported to grails 7, we are disabling
+ // until this can be finished ported to the current Grails release, we are disabling
Review Comment:
The comment has a grammatical error (“finished ported”). Consider rephrasing to “finished being ported” (or similar) to keep the note clear.
##########
settings.gradle:
##########
@@ -267,7 +267,7 @@ project(':grails-gsp-spring-boot').projectDir = file('grails-gsp/spring-boot')
// Data Mapping - Documentation
include 'grails-data-docs-guide-developer'
project(':grails-data-docs-guide-developer').projectDir = file('grails-data-docs/guide-developer')
-// until this can be finished ported to grails 7, we are disabling
+// until this can be finished ported to the current Grails release, we are disabling
Review Comment:
The comment has a grammatical error (“finished ported”). Consider rephrasing to “finished being ported” (or similar) to keep the note clear.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@grails.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Use config-driven Grails version docs [grails-core]
Posted by "jamesfredley (via GitHub)" <gi...@apache.org>.
jamesfredley commented on code in PR #15769:
URL: https://github.com/apache/grails-core/pull/15769#discussion_r3480681126
##########
settings.gradle:
##########
@@ -205,7 +205,7 @@ include(
'grails-datamapping-core-test',
// RX projects
- // until this can be finished ported to grails 7, we are disabling
+ // until this can be finished ported to the current Grails release, we are disabling
Review Comment:
Addressed in 6bd3370f79 by rephrasing the comment to 'finished being ported'.
##########
settings.gradle:
##########
@@ -267,7 +267,7 @@ project(':grails-gsp-spring-boot').projectDir = file('grails-gsp/spring-boot')
// Data Mapping - Documentation
include 'grails-data-docs-guide-developer'
project(':grails-data-docs-guide-developer').projectDir = file('grails-data-docs/guide-developer')
-// until this can be finished ported to grails 7, we are disabling
+// until this can be finished ported to the current Grails release, we are disabling
Review Comment:
Addressed in 6bd3370f79 by rephrasing the comment to 'finished being ported'.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@grails.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org