You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2021/05/25 08:56:17 UTC
[GitHub] [dolphinscheduler] ruanwenjun opened a new issue #5546: [Improvement][Api] Adding transaction when update process definition
ruanwenjun opened a new issue #5546:
URL: https://github.com/apache/dolphinscheduler/issues/5546
**Describe the question**
When we update a process definition, we need to perform multiple DML operations, it is needed to add transaction to ensure the data is consistent when an exception occurs.
https://github.com/apache/dolphinscheduler/blob/842c5400e605a8b8eb0d8fdc78701f10222063fd/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/ProcessDefinitionServiceImpl.java#L375
https://github.com/apache/dolphinscheduler/blob/842c5400e605a8b8eb0d8fdc78701f10222063fd/dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java#L2228
There are also some other method need to check, such as:
https://github.com/apache/dolphinscheduler/blob/842c5400e605a8b8eb0d8fdc78701f10222063fd/dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java#L2367
https://github.com/apache/dolphinscheduler/blob/842c5400e605a8b8eb0d8fdc78701f10222063fd/dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java#L2376
**Which version of DolphinScheduler:**
-[dev]
**Describe alternatives you've considered**
Add transaction, and it is recommended to split ProcessService into CommandService、ProcessDefinitionService、ProcessInstanceService、TaskService
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] HomminLee commented on issue #5546: [Improvement][Api] Adding transaction when update process definition
Posted by GitBox <gi...@apache.org>.
HomminLee commented on issue #5546:
URL: https://github.com/apache/dolphinscheduler/issues/5546#issuecomment-961666604
I want to take this issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] HomminLee commented on issue #5546: [Improvement][Api] Adding transaction when update process definition
Posted by GitBox <gi...@apache.org>.
HomminLee commented on issue #5546:
URL: https://github.com/apache/dolphinscheduler/issues/5546#issuecomment-968754992
@ruanwenjun I have a question. Class ProcessService exists in project [dolphinscheduler-service], and there are already exists ProcessDefinitionService、ProcessInstanceService、TaskInstanceService in project [dolphinscheduler-api]. In my previous thoughts, I want split ProcessService to those service class. But I found ProcessService also be used by project [dolphinscheduler-server]. If I follow the previous ideas to complete, the project [dolphinscheduler-api] cannot use those service, this is unacceptable.
So, do you have any suggestions? Should I just create 4 new class in project [dolphinscheduler-service] with other names?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] github-actions[bot] commented on issue #5546: [Improvement][Api] Adding transaction when update process definition
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on issue #5546:
URL: https://github.com/apache/dolphinscheduler/issues/5546#issuecomment-847686163
Hi:
* Thank you for your feedback, we have received your issue, Please wait patiently for a reply.
* In order for us to understand your request as soon as possible, please provide detailed information、version or pictures.
* If you haven't received a reply for a long time, you can subscribe to the developer's email，Mail subscription steps reference https://dolphinscheduler.apache.org/zh-cn/community/development/subscribe.html ,Then write the issue URL in the email content and send question to dev@dolphinscheduler.apache.org.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] github-actions[bot] removed a comment on issue #5546: [Improvement][Api] Adding transaction when update process definition
Posted by GitBox <gi...@apache.org>.
github-actions[bot] removed a comment on issue #5546:
URL: https://github.com/apache/dolphinscheduler/issues/5546#issuecomment-847686163
Hi:
* Thank you for your feedback, we have received your issue, Please wait patiently for a reply.
* In order for us to understand your request as soon as possible, please provide detailed information、version or pictures.
* If you haven't received a reply for a long time, you can subscribe to the developer's email，Mail subscription steps reference https://dolphinscheduler.apache.org/zh-cn/community/development/subscribe.html ,Then write the issue URL in the email content and send question to dev@dolphinscheduler.apache.org.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] github-actions[bot] commented on issue #5546: [Improvement][Api] Adding transaction when update process definition
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on issue #5546:
URL: https://github.com/apache/dolphinscheduler/issues/5546#issuecomment-1046130270
This issue has been automatically marked as stale because it has not had recent activity for 30 days. It will be closed in next 7 days if no further activity occurs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] ji04xiaogang commented on issue #5546: [Improvement][Api] Adding transaction when update process definition
Posted by GitBox <gi...@apache.org>.
ji04xiaogang commented on issue #5546:
URL: https://github.com/apache/dolphinscheduler/issues/5546#issuecomment-870195983
I would like to contribute to this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] ruanwenjun commented on issue #5546: [Improvement][Api] Adding transaction when update process definition
Posted by GitBox <gi...@apache.org>.
ruanwenjun commented on issue #5546:
URL: https://github.com/apache/dolphinscheduler/issues/5546#issuecomment-968796521
@HomminLee You can create a new issue to track your idea.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] HomminLee commented on issue #5546: [Improvement][Api] Adding transaction when update process definition
Posted by GitBox <gi...@apache.org>.
HomminLee commented on issue #5546:
URL: https://github.com/apache/dolphinscheduler/issues/5546#issuecomment-961666604
I want to take this issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] github-actions[bot] commented on issue #5546: [Improvement][Api] Adding transaction when update process definition
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on issue #5546:
URL: https://github.com/apache/dolphinscheduler/issues/5546#issuecomment-1053736526
This issue has been closed because it has not received response for too long time. You could reopen it if you encountered similar problems in the future.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] ji04xiaogang commented on issue #5546: [Improvement][Api] Adding transaction when update process definition
Posted by GitBox <gi...@apache.org>.
ji04xiaogang commented on issue #5546:
URL: https://github.com/apache/dolphinscheduler/issues/5546#issuecomment-870195983
I would like to contribute to this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] HomminLee commented on issue #5546: [Improvement][Api] Adding transaction when update process definition
Posted by GitBox <gi...@apache.org>.
HomminLee commented on issue #5546:
URL: https://github.com/apache/dolphinscheduler/issues/5546#issuecomment-961666604
I want to take this issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] github-actions[bot] closed issue #5546: [Improvement][Api] Adding transaction when update process definition
Posted by GitBox <gi...@apache.org>.
github-actions[bot] closed issue #5546:
URL: https://github.com/apache/dolphinscheduler/issues/5546
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] JinyLeeChina edited a comment on issue #5546: [Improvement][Api] Adding transaction when update process definition
Posted by GitBox <gi...@apache.org>.
JinyLeeChina edited a comment on issue #5546:
URL: https://github.com/apache/dolphinscheduler/issues/5546#issuecomment-966262308
@ruanwenjun Please confirm that the current interface already supports transactions
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] JinyLeeChina commented on issue #5546: [Improvement][Api] Adding transaction when update process definition
Posted by GitBox <gi...@apache.org>.
JinyLeeChina commented on issue #5546:
URL: https://github.com/apache/dolphinscheduler/issues/5546#issuecomment-966262308
@ruanwenjun ruan Please confirm that the current interface already supports transactions
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org