You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Rich Seller (JIRA)" <ji...@codehaus.org> on 2008/06/24 19:43:27 UTC
[jira] Created: (MRELEASE-358) CheckDependencySnapshotsPhase fails
when resolving all dependencies
CheckDependencySnapshotsPhase fails when resolving all dependencies
-------------------------------------------------------------------
Key: MRELEASE-358
URL: http://jira.codehaus.org/browse/MRELEASE-358
Project: Maven 2.x Release Plugin
Issue Type: Bug
Affects Versions: 2.0-beta-7
Reporter: Rich Seller
Attachments: patch.txt
In CheckDependencySnapshotsPhase, if '0' (All) is selected in response to the prompt "specify the selection number ..." the dependencies are not removed from the original set, so a ReleaseFailureException is thrown at the end of checkProject().
In the attached patch the dependencies are removed from the original set, and the snapshotSet is returned from resolveSnapshots() to be checked in checkProject().
In the tests, I implemented a custom Prompter because I don't know how to set multiple conditional responses on JMock1 mocks.
One other change made while testing: in processSnapshot, "What is the next development version?" is set with a singleton list so a different value has been entered. I removed the list to make the supplied value the default but allow different responses. I can raise this as a separate issue if required
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MRELEASE-358) CheckDependencySnapshotsPhase fails
when resolving all dependencies
Posted by "Arnaud Heritier (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MRELEASE-358?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Arnaud Heritier updated MRELEASE-358:
-------------------------------------
Component/s: prepare
> CheckDependencySnapshotsPhase fails when resolving all dependencies
> -------------------------------------------------------------------
>
> Key: MRELEASE-358
> URL: http://jira.codehaus.org/browse/MRELEASE-358
> Project: Maven 2.x Release Plugin
> Issue Type: Bug
> Components: prepare
> Affects Versions: 2.0-beta-7
> Reporter: Rich Seller
> Attachments: patch.txt
>
>
> In CheckDependencySnapshotsPhase, if '0' (All) is selected in response to the prompt "specify the selection number ..." the dependencies are not removed from the original set, so a ReleaseFailureException is thrown at the end of checkProject().
> In the attached patch the dependencies are removed from the original set, and the snapshotSet is returned from resolveSnapshots() to be checked in checkProject().
> In the tests, I implemented a custom Prompter because I don't know how to set multiple conditional responses on JMock1 mocks.
> One other change made while testing: in processSnapshot, "What is the next development version?" is set with a singleton list so a different value has been entered. I removed the list to make the supplied value the default but allow different responses. I can raise this as a separate issue if required
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] (MRELEASE-358) CheckDependencySnapshotsPhase fails when
resolving all dependencies
Posted by "Robert Scholte (JIRA)" <ji...@codehaus.org>.
[ https://jira.codehaus.org/browse/MRELEASE-358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=294149#comment-294149 ]
Robert Scholte commented on MRELEASE-358:
-----------------------------------------
The patch is not complete, it's missing the unversioned files. The code has changed quite a lot since this issue was filed, so I can't say it's fixed by only looking at the patch.
@Rich, could you confirm this is fixed? Otherwise attach the test with the missing files.
If there's no response I'll have to close it as {{incomplete}}.
> CheckDependencySnapshotsPhase fails when resolving all dependencies
> -------------------------------------------------------------------
>
> Key: MRELEASE-358
> URL: https://jira.codehaus.org/browse/MRELEASE-358
> Project: Maven 2.x Release Plugin
> Issue Type: Bug
> Components: prepare
> Affects Versions: 2.0-beta-7
> Reporter: Rich Seller
> Attachments: patch.txt
>
>
> In CheckDependencySnapshotsPhase, if '0' (All) is selected in response to the prompt "specify the selection number ..." the dependencies are not removed from the original set, so a ReleaseFailureException is thrown at the end of checkProject().
> In the attached patch the dependencies are removed from the original set, and the snapshotSet is returned from resolveSnapshots() to be checked in checkProject().
> In the tests, I implemented a custom Prompter because I don't know how to set multiple conditional responses on JMock1 mocks.
> One other change made while testing: in processSnapshot, "What is the next development version?" is set with a singleton list so a different value has been entered. I removed the list to make the supplied value the default but allow different responses. I can raise this as a separate issue if required
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MRELEASE-358) CheckDependencySnapshotsPhase
fails when resolving all dependencies
Posted by "Brett Porter (JIRA)" <ji...@codehaus.org>.
[ https://jira.codehaus.org/browse/MRELEASE-358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=271346#comment-271346 ]
Brett Porter commented on MRELEASE-358:
---------------------------------------
this may be related to MRELEASE-350
> CheckDependencySnapshotsPhase fails when resolving all dependencies
> -------------------------------------------------------------------
>
> Key: MRELEASE-358
> URL: https://jira.codehaus.org/browse/MRELEASE-358
> Project: Maven 2.x Release Plugin
> Issue Type: Bug
> Components: prepare
> Affects Versions: 2.0-beta-7
> Reporter: Rich Seller
> Attachments: patch.txt
>
>
> In CheckDependencySnapshotsPhase, if '0' (All) is selected in response to the prompt "specify the selection number ..." the dependencies are not removed from the original set, so a ReleaseFailureException is thrown at the end of checkProject().
> In the attached patch the dependencies are removed from the original set, and the snapshotSet is returned from resolveSnapshots() to be checked in checkProject().
> In the tests, I implemented a custom Prompter because I don't know how to set multiple conditional responses on JMock1 mocks.
> One other change made while testing: in processSnapshot, "What is the next development version?" is set with a singleton list so a different value has been entered. I removed the list to make the supplied value the default but allow different responses. I can raise this as a separate issue if required
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MRELEASE-358) CheckDependencySnapshotsPhase
fails when resolving all dependencies
Posted by "Rich Seller (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MRELEASE-358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=168210#action_168210 ]
Rich Seller commented on MRELEASE-358:
--------------------------------------
Has anybody had a chance to look at this yet?
> CheckDependencySnapshotsPhase fails when resolving all dependencies
> -------------------------------------------------------------------
>
> Key: MRELEASE-358
> URL: http://jira.codehaus.org/browse/MRELEASE-358
> Project: Maven 2.x Release Plugin
> Issue Type: Bug
> Components: prepare
> Affects Versions: 2.0-beta-7
> Reporter: Rich Seller
> Attachments: patch.txt
>
>
> In CheckDependencySnapshotsPhase, if '0' (All) is selected in response to the prompt "specify the selection number ..." the dependencies are not removed from the original set, so a ReleaseFailureException is thrown at the end of checkProject().
> In the attached patch the dependencies are removed from the original set, and the snapshotSet is returned from resolveSnapshots() to be checked in checkProject().
> In the tests, I implemented a custom Prompter because I don't know how to set multiple conditional responses on JMock1 mocks.
> One other change made while testing: in processSnapshot, "What is the next development version?" is set with a singleton list so a different value has been entered. I removed the list to make the supplied value the default but allow different responses. I can raise this as a separate issue if required
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Issue Comment Edited: (MRELEASE-358)
CheckDependencySnapshotsPhase fails when resolving all dependencies
Posted by "Brett Porter (JIRA)" <ji...@codehaus.org>.
[ https://jira.codehaus.org/browse/MRELEASE-358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=271346#comment-271346 ]
Brett Porter edited comment on MRELEASE-358 at 6/25/11 3:18 AM:
----------------------------------------------------------------
this may be related to MRELEASE-350, can someone re-test with 2.1?
was (Author: brettporter):
this may be related to MRELEASE-350
> CheckDependencySnapshotsPhase fails when resolving all dependencies
> -------------------------------------------------------------------
>
> Key: MRELEASE-358
> URL: https://jira.codehaus.org/browse/MRELEASE-358
> Project: Maven 2.x Release Plugin
> Issue Type: Bug
> Components: prepare
> Affects Versions: 2.0-beta-7
> Reporter: Rich Seller
> Attachments: patch.txt
>
>
> In CheckDependencySnapshotsPhase, if '0' (All) is selected in response to the prompt "specify the selection number ..." the dependencies are not removed from the original set, so a ReleaseFailureException is thrown at the end of checkProject().
> In the attached patch the dependencies are removed from the original set, and the snapshotSet is returned from resolveSnapshots() to be checked in checkProject().
> In the tests, I implemented a custom Prompter because I don't know how to set multiple conditional responses on JMock1 mocks.
> One other change made while testing: in processSnapshot, "What is the next development version?" is set with a singleton list so a different value has been entered. I removed the list to make the supplied value the default but allow different responses. I can raise this as a separate issue if required
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira