[GitHub] [cassandra] dcapwell commented on a diff in pull request #1684: CASSANDRA-17151 trunk: Add guardrail for column value size

[GitBox <gi...@apache.org>]

dcapwell commented on code in PR #1684:
URL: https://github.com/apache/cassandra/pull/1684#discussion_r941844569


##########
conf/cassandra.yaml:
##########
@@ -1752,6 +1752,17 @@ drop_compact_storage_enabled: false
 # write_consistency_levels_warned: []
 # write_consistency_levels_disallowed: []
 #
+# Guardrail to warn or fail when writing column values larger than threshold.
+# This guardrail is only applied to the values of regular columns because both the serialized partitions keys and the
+# values of the components of the clustering key already have a fixed, relatively small size limit of 65535 bytes, which
+# is probably lesser than the thresholds defined here.
+# This guardrail is different to max_value_size. max_value_size is checked when deserializing any value to detect
+# sstable corruption, whereas this guardrail is checked on the CQL layer at write time to reject regular user queries
+# inserting too large columns.
+# Default -1 to disable.

Review Comment:
   `Invalid data storage: value must be non-negative` will be thrown if you do that, as you use `DataStorageSpec.LongBytesBound` which doesn't allow `null`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org