You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/12/21 01:57:54 UTC

[GitHub] [doris] morningman commented on a diff in pull request #15216: [fix](jdbc catalog) fix bugs of jdbc catalog and table valued function

morningman commented on code in PR #15216:
URL: https://github.com/apache/doris/pull/15216#discussion_r1053905729


##########
fe/fe-core/src/main/java/org/apache/doris/external/jdbc/JdbcClient.java:
##########
@@ -338,6 +341,14 @@ public Type mysqlTypeToDoris(JdbcFieldSchema fieldSchema) {
                     return Type.BIGINT;
                 case "BIGINT":
                     return ScalarType.createStringType();
+                case "DECIMAL":

Review Comment:
   Please add regression test for this case



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org