You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tinkerpop.apache.org by "Cole-Greer (via GitHub)" <gi...@apache.org> on 2023/06/29 00:53:51 UTC
[GitHub] [tinkerpop] Cole-Greer opened a new pull request, #2113: Tinkerpop 2954 - Pass Gremlin Version from Maven to Sources Without Manifests
Cole-Greer opened a new pull request, #2113:
URL: https://github.com/apache/tinkerpop/pull/2113
https://issues.apache.org/jira/browse/TINKERPOP-2954
This PR removes the old jcabi manifest system to pass the project version from maven into java. The new system uses `com.google.code.maven-replacer-plugin` to directly inject the project version into the source code of gremlin-core and the GLV's. This system will inject the current project version into the source code during the `generate-sources` phase in maven anytime something such as `mvn clean install` is run. It can also be triggered manually by running `mvn replacer:replace`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tinkerpop] xiazcy commented on pull request #2113: TINKERPOP-2954 - Pass Gremlin Version from Maven to Sources Without Manifests
Posted by "xiazcy (via GitHub)" <gi...@apache.org>.
xiazcy commented on PR #2113:
URL: https://github.com/apache/tinkerpop/pull/2113#issuecomment-1620613898
VOTE +1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tinkerpop] vkagamlyk commented on pull request #2113: Tinkerpop-2954 - Pass Gremlin Version from Maven to Sources Without Manifests
Posted by "vkagamlyk (via GitHub)" <gi...@apache.org>.
vkagamlyk commented on PR #2113:
URL: https://github.com/apache/tinkerpop/pull/2113#issuecomment-1613545730
LGTM, VOTE+1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tinkerpop] codecov-commenter commented on pull request #2113: Tinkerpop-2954 - Pass Gremlin Version from Maven to Sources Without Manifests
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #2113:
URL: https://github.com/apache/tinkerpop/pull/2113#issuecomment-1612296925
## [Codecov](https://app.codecov.io/gh/apache/tinkerpop/pull/2113?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#2113](https://app.codecov.io/gh/apache/tinkerpop/pull/2113?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (bed33ac) into [3.5-dev](https://app.codecov.io/gh/apache/tinkerpop/commit/6ef9fa1221e42ceb89bb77bc964425aaa7451d2d?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (6ef9fa1) will **increase** coverage by `0.18%`.
> The diff coverage is `n/a`.
> :exclamation: Current head bed33ac differs from pull request most recent head 607e966. Consider uploading reports for the commit 607e966 to get more accurate results
```diff
@@ Coverage Diff @@
## 3.5-dev #2113 +/- ##
=============================================
+ Coverage 69.91% 70.10% +0.18%
=============================================
Files 865 24 -841
Lines 40980 3532 -37448
Branches 5450 0 -5450
=============================================
- Hits 28650 2476 -26174
+ Misses 10430 884 -9546
+ Partials 1900 172 -1728
```
[see 852 files with indirect coverage changes](https://app.codecov.io/gh/apache/tinkerpop/pull/2113/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tinkerpop] Cole-Greer merged pull request #2113: TINKERPOP-2954 - Pass Gremlin Version from Maven to Sources Without Manifests
Posted by "Cole-Greer (via GitHub)" <gi...@apache.org>.
Cole-Greer merged PR #2113:
URL: https://github.com/apache/tinkerpop/pull/2113
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org