[GitHub] [incubator-druid] capistrant commented on a change in pull request #7145: Enhance the Http Firehose to work with URIs requiring basic authentication

[GitBox <gi...@apache.org>]

capistrant commented on a change in pull request #7145: Enhance the Http Firehose to work with URIs requiring basic authentication
URL: https://github.com/apache/incubator-druid/pull/7145#discussion_r273100319
 
 

 ##########
 File path: indexing-service/src/main/java/org/apache/druid/indexing/worker/executor/ExecutorLifecycle.java
 ##########
 @@ -80,7 +83,7 @@ public ExecutorLifecycle(
     this.taskConfig = taskConfig;
     this.taskActionClientFactory = taskActionClientFactory;
     this.taskRunner = taskRunner;
-    this.jsonMapper = jsonMapper;
+    this.jsonMapper = new DefaultObjectMapper((DefaultObjectMapper) jsonMapper).addMixIn(PasswordProvider.class, PasswordProviderRedactionMixIn.class);
 
 Review comment:
   @jihoonson When I do not swap out the ObjectMapper with a new one that has the MixIn, the password is written in plaintext to the metastore and the task log file. Both of those instances serialize the object to JSON using the existing ObjectMapper before writing, so I don't think that the ObjectMapper is configured to recognize and omit the password as needed. Also, since the way the indexing service works requires the Serialization to selectively include the password in the json (when the overlord is assigning a remote worker), changing the default object mapper to handle this new block would not work either. That is why I felt the need to use a MixIn

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org