You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/08/10 14:40:18 UTC

[GitHub] [incubator-nuttx] patacongo commented on a change in pull request #1550: Correct CROMFS hardlink handling

patacongo commented on a change in pull request #1550:
URL: https://github.com/apache/incubator-nuttx/pull/1550#discussion_r467951299



##########
File path: tools/gencromfs.c
##########
@@ -111,7 +111,7 @@
 #define NUTTX_IFLNK        (10 << 12)  /* Must match NuttX's S_IFLNK */
 
 #define DIR_MODEFLAGS      (NUTTX_IFDIR | NUTTX_IRXUSR | NUTTX_IRXGRP | NUTTX_IRXOTH)
-#define DIRLINK_MODEFLAGS  (NUTTX_IFLNK | DIR_MODEFLAGS)
+#define DIRLINK_MODEFLAGS  (NUTTX_IFLNK | NUTTX_IRXUSR | NUTTX_IRXGRP | NUTTX_IRXOTH)

Review comment:
       This part of the PR looks correct.  The rest is wrong.  Can we commit this separately?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org