[GitHub] [spark] dongjoon-hyun commented on issue #26430: [SPARK-28859][Core] Requires MEMORY_OFFHEAP_SIZE value must be > 0 when user specifies

[GitBox <gi...@apache.org>]

dongjoon-hyun commented on issue #26430: [SPARK-28859][Core] Requires MEMORY_OFFHEAP_SIZE value must be > 0 when user specifies
URL: https://github.com/apache/spark/pull/26430#issuecomment-554217775
 
 
   Sorry, @xingyif . It seems that this PR causes `1,588 failures` in Apache Spark unit tests due to the contradiction. `checkValue` is called at `TypedConfigBuilder.createWithDefault`.
   ```
   sbt.ForkMain$ForkError: sbt.ForkMain$ForkError: java.lang.ExceptionInInitializerError: null
   	at org.apache.spark.SparkConf$.<init>(SparkConf.scala:639)
   	at org.apache.spark.SparkConf$.<clinit>(SparkConf.scala)
   	at org.apache.spark.SparkConf.set(SparkConf.scala:94)
   	at org.apache.spark.SparkConf.$anonfun$loadFromSystemProperties$3(SparkConf.scala:76)
   ...
   Caused by: sbt.ForkMain$ForkError: sbt.ForkMain$ForkError:
   java.lang.IllegalArgumentException: The off-heap memory size must be positive.
   	at org.apache.spark.internal.config.TypedConfigBuilder.$anonfun$checkValue$1(ConfigBuilder.scala:107)
   	at org.apache.spark.internal.config.TypedConfigBuilder.$anonfun$transform$1(ConfigBuilder.scala:101)
   	at org.apache.spark.internal.config.TypedConfigBuilder.createWithDefault(ConfigBuilder.scala:144)
   	at org.apache.spark.internal.config.package$.<init>(package.scala:273)
   	at org.apache.spark.internal.config.package$.<clinit>(package.scala)
   	... 25 more
   ```
   
   Since `MemoryManager.scala` already validates the condition and throws exception correctly. I'll close this PR.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org