You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by GitBox <gi...@apache.org> on 2022/07/25 14:03:11 UTC
[GitHub] [lucene-jira-archive] mikemccand opened a new pull request, #80: #79: include parent issue link
mikemccand opened a new pull request, #80:
URL: https://github.com/apache/lucene-jira-archive/pull/80
Render the parent link in the `Legacy Jira` section.
I also removed ` details` from `Legacy Jira details` header. It seemed redundant / self-explanatory already.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-jira-archive] mikemccand commented on a diff in pull request #80: #79: include parent issue link
Posted by GitBox <gi...@apache.org>.
mikemccand commented on code in PR #80:
URL: https://github.com/apache/lucene-jira-archive/pull/80#discussion_r928980448
##########
migration/src/jira_util.py:
##########
@@ -83,6 +83,15 @@ def extract_assignee(o: dict) -> tuple[str, str]:
return (name, disp_name)
+def extract_parent(o: dict) -> tuple[str, str]:
+ parent = o["fields"].get("parent")
+ if parent:
+ key = parent["key"]
+ if key:
+ return key, f'https://issues.apache.org/jira/browse/{key}'
Review Comment:
Ahh good idea, will do.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-jira-archive] mikemccand merged pull request #80: #79: include parent issue link
Posted by GitBox <gi...@apache.org>.
mikemccand merged PR #80:
URL: https://github.com/apache/lucene-jira-archive/pull/80
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-jira-archive] mocobeta commented on a diff in pull request #80: #79: include parent issue link
Posted by GitBox <gi...@apache.org>.
mocobeta commented on code in PR #80:
URL: https://github.com/apache/lucene-jira-archive/pull/80#discussion_r928947072
##########
migration/src/jira_util.py:
##########
@@ -83,6 +83,15 @@ def extract_assignee(o: dict) -> tuple[str, str]:
return (name, disp_name)
+def extract_parent(o: dict) -> tuple[str, str]:
+ parent = o["fields"].get("parent")
+ if parent:
+ key = parent["key"]
+ if key:
+ return key, f'https://issues.apache.org/jira/browse/{key}'
Review Comment:
I would just extract the key and make the url on-the-fly at `jir2github_import.py` (L120).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org