You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by GitBox <gi...@apache.org> on 2023/01/06 13:15:47 UTC
[GitHub] [zeppelin] Reamer opened a new pull request, #4545: CI broken
Reamer opened a new pull request, #4545:
URL: https://github.com/apache/zeppelin/pull/4545
### What is this PR for?
At the moment the CI is broken. This PullRequest is intended to be a common basis to fix the error quickly.
### What type of PR is it?
Bug Fix
### Todos
* [ ] - Fix CI
### How should this be tested?
* via current CI
### Questions:
* Does the license files need to update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] Reamer commented on pull request #4545: CI broken
Posted by GitBox <gi...@apache.org>.
Reamer commented on PR #4545:
URL: https://github.com/apache/zeppelin/pull/4545#issuecomment-1373762162
Found the following error inside log. Therefore I created [ZEPPELIN-5861](https://issues.apache.org/jira/projects/ZEPPELIN/issues/ZEPPELIN-5861)
```
2023-01-06T14:50:16.2093997Z [INFO] Interpreter launch command: /opt/hostedtoolcache/Java_Temurin-Hotspot_jdk/8.0.352-8/x64/bin/java -Dfile.encoding=UTF-8 -Dlog4j.configuration=file:///home/runner/work/zeppelin/zeppelin/conf/log4j.properties -Dlog4j.configurationFile=file:///home/runner/work/zeppelin/zeppelin/conf/log4j2.properties -Dzeppelin.log.file=/home/runner/work/zeppelin/zeppelin/logs/zeppelin-interpreter-test-shared_process--fv-az335-610.log -Xmx1024m -cp :/home/runner/work/zeppelin/zeppelin/zeppelin-zengine/../local-repo/test/*:/home/runner/work/zeppelin/zeppelin/zeppelin-zengine/../interpreter_RemoteAngularObjectTest/test/*:/home/runner/work/zeppelin/zeppelin/zeppelin-interpreter-shaded/target/*:/home/runner/work/zeppelin/zeppelin/zeppelin-zengine/target/test-classes/*:::/home/runner/work/zeppelin/zeppelin/interpreter/zeppelin-interpreter-shaded-0.11.0-SNAPSHOT.jar:/home/runner/work/zeppelin/zeppelin/zeppelin-interpreter/target/classes:/home/runner/work/zeppelin/zeppelin
/zeppelin-zengine/target/test-classes org.apache.zeppelin.interpreter.remote.RemoteInterpreterServer 127.0.0.1 42277 test-shared_process :
2023-01-06T14:50:16.2095863Z
2023-01-06T14:50:16.2096005Z -------------------
2023-01-06T14:50:16.2096480Z at org.apache.zeppelin.interpreter.remote.RemoteAngularObjectTest.setUp(RemoteAngularObjectTest.java:72)
2023-01-06T14:50:16.2096958Z Caused by: java.io.IOException:
2023-01-06T14:50:16.2097229Z Fail to launch interpreter process:
2023-01-06T14:50:16.2097501Z -------------------
2023-01-06T14:50:16.2100576Z Interpreter download command: /opt/hostedtoolcache/Java_Temurin-Hotspot_jdk/8.0.352-8/x64/bin/java -Dfile.encoding=UTF-8 -Dlog4j.configuration=file:///home/runner/work/zeppelin/zeppelin/conf/log4j.properties -Dlog4j.configurationFile=file:///home/runner/work/zeppelin/zeppelin/conf/log4j2.properties -Dzeppelin.log.file=/home/runner/work/zeppelin/zeppelin/logs/zeppelin-interpreter-test-shared_process--fv-az335-610.log -cp :/home/runner/work/zeppelin/zeppelin/zeppelin-zengine/../interpreter_RemoteAngularObjectTest/test/*:/home/runner/work/zeppelin/zeppelin/zeppelin-interpreter-shaded/target/*:/home/runner/work/zeppelin/zeppelin/zeppelin-zengine/target/test-classes/*:::/home/runner/work/zeppelin/zeppelin/interpreter/zeppelin-interpreter-shaded-0.11.0-SNAPSHOT.jar:/home/runner/work/zeppelin/zeppelin/zeppelin-interpreter/target/classes:/home/runner/work/zeppelin/zeppelin/zeppelin-zengine/target/test-classes org.apache.zeppelin.interpreter.remote.RemoteInterp
reterDownloader 127.0.0.1 42277 test /home/runner/work/zeppelin/zeppelin/zeppelin-zengine/../local-repo/test
2023-01-06T14:50:16.2113231Z ##[error]Exception in thread "main" java.lang.IllegalArgumentException: Unable to create EvictionPolicy instance of type org/apache/zeppelin/shaded/org.apache.zeppelin.shaded.org.apache.commons.pool2.impl.DefaultEvictionPolicy
2023-01-06T14:50:16.2114631Z at org.apache.zeppelin.shaded.org.apache.commons.pool2.impl.BaseGenericObjectPool.setEvictionPolicyClassName(BaseGenericObjectPool.java:607)
2023-01-06T14:50:16.2115551Z at org.apache.zeppelin.shaded.org.apache.commons.pool2.impl.GenericObjectPool.setConfig(GenericObjectPool.java:321)
2023-01-06T14:50:16.2116321Z at org.apache.zeppelin.shaded.org.apache.commons.pool2.impl.GenericObjectPool.<init>(GenericObjectPool.java:117)
2023-01-06T14:50:16.2116986Z at org.apache.zeppelin.interpreter.remote.PooledRemoteClient.<init>(PooledRemoteClient.java:47)
2023-01-06T14:50:16.2117647Z at org.apache.zeppelin.interpreter.remote.RemoteInterpreterEventClient.<init>(RemoteInterpreterEventClient.java:67)
2023-01-06T14:50:16.2118381Z at org.apache.zeppelin.interpreter.remote.RemoteInterpreterDownloader.main(RemoteInterpreterDownloader.java:58)
2023-01-06T14:50:16.2119172Z Caused by: java.lang.ClassNotFoundException: org/apache/zeppelin/shaded/org.apache.zeppelin.shaded.org.apache.commons.pool2.impl.DefaultEvictionPolicy
2023-01-06T14:50:16.2119735Z at java.lang.Class.forName0(Native Method)
2023-01-06T14:50:16.2120042Z at java.lang.Class.forName(Class.java:348)
2023-01-06T14:50:16.2120715Z at org.apache.zeppelin.shaded.org.apache.commons.pool2.impl.BaseGenericObjectPool.setEvictionPolicyClassName(BaseGenericObjectPool.java:598)
2023-01-06T14:50:16.2121304Z ... 5 more
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] kriegaex commented on a diff in pull request #4545: CI broken
Posted by GitBox <gi...@apache.org>.
kriegaex commented on code in PR #4545:
URL: https://github.com/apache/zeppelin/pull/4545#discussion_r1064453968
##########
zeppelin-interpreter-shaded/pom.xml:
##########
@@ -33,7 +33,7 @@
<description>Zeppelin Interpreter Shaded</description>
<properties>
- <shaded.dependency.prefix>org.apache.zeppelin.shaded</shaded.dependency.prefix>
+ <shaded.dependency.prefix>shaded</shaded.dependency.prefix>
Review Comment:
I agree with @Reamer that this config snippet is unrelated to the two Maven Shade issues mentioned in his comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] jongyoul commented on pull request #4545: CI broken
Posted by GitBox <gi...@apache.org>.
jongyoul commented on PR #4545:
URL: https://github.com/apache/zeppelin/pull/4545#issuecomment-1374327740
Oh.. Interesting.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] jongyoul merged pull request #4545: [ZEPPELIN-5861] Correct shading Prefix
Posted by "jongyoul (via GitHub)" <gi...@apache.org>.
jongyoul merged PR #4545:
URL: https://github.com/apache/zeppelin/pull/4545
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] jongyoul commented on pull request #4545: CI broken
Posted by GitBox <gi...@apache.org>.
jongyoul commented on PR #4545:
URL: https://github.com/apache/zeppelin/pull/4545#issuecomment-1387164198
I think it's good but I just have one question. Is there any critical reason that we changed `test` to `verify`? It looks similar and `verify` is running after `test` and `package`, and sometimes it uses more time. So I just wonder why `verify` is better than `test` in our cases.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] Reamer commented on pull request #4545: CI broken
Posted by GitBox <gi...@apache.org>.
Reamer commented on PR #4545:
URL: https://github.com/apache/zeppelin/pull/4545#issuecomment-1375722112
The next error, which occurs frequently, is as follows.
```
2023-01-06T17:43:32.9579892Z [ERROR] testIPythonProcessKilled Time elapsed: 3.305 s <<< ERROR!
2023-01-06T17:43:32.9588899Z org.apache.zeppelin.interpreter.InterpreterException: java.lang.NoClassDefFoundError: io/grpc/stub/StreamObserver
2023-01-06T17:43:32.9597447Z at org.apache.zeppelin.spark.IPySparkInterpreterTest.startInterpreter(IPySparkInterpreterTest.java:98)
2023-01-06T17:43:32.9604208Z Caused by: java.lang.NoClassDefFoundError: io/grpc/stub/StreamObserver
2023-01-06T17:43:32.9612809Z at org.apache.zeppelin.spark.IPySparkInterpreterTest.startInterpreter(IPySparkInterpreterTest.java:98)
2023-01-06T17:43:32.9619547Z Caused by: java.lang.ClassNotFoundException: io.grpc.stub.StreamObserver
2023-01-06T17:43:32.9627967Z at org.apache.zeppelin.spark.IPySparkInterpreterTest.startInterpreter(IPySparkInterpreterTest.java:98)
```
We find the class `io/grpc/stub/StreamObserver` as a dependency in `zeppelin-jupyter-interpreter`.
https://github.com/apache/zeppelin/blob/deb7f3b1c4c4a1b82ef85e59a327f7c8ad6f4714/zeppelin-jupyter-interpreter/pom.xml#L65-L69
`zeppelin-jupyter-interpreter` is a compile dependency of the `spark-interpreter`
https://github.com/apache/zeppelin/blob/deb7f3b1c4c4a1b82ef85e59a327f7c8ad6f4714/spark/interpreter/pom.xml#L105-L119
At the moment I don't know where the problem is.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] Reamer commented on pull request #4545: CI broken
Posted by GitBox <gi...@apache.org>.
Reamer commented on PR #4545:
URL: https://github.com/apache/zeppelin/pull/4545#issuecomment-1382117894
@zjffdu
Do you have any idea how to fix the Flink compilation? I find the setup with the symlink of `flink-scala-parent` very unattractive, this does not seem clean.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] Reamer commented on a diff in pull request #4545: CI broken
Posted by GitBox <gi...@apache.org>.
Reamer commented on code in PR #4545:
URL: https://github.com/apache/zeppelin/pull/4545#discussion_r1064361473
##########
zeppelin-interpreter-shaded/pom.xml:
##########
@@ -33,7 +33,7 @@
<description>Zeppelin Interpreter Shaded</description>
<properties>
- <shaded.dependency.prefix>org.apache.zeppelin.shaded</shaded.dependency.prefix>
+ <shaded.dependency.prefix>shaded</shaded.dependency.prefix>
Review Comment:
> is it necessary? I believe it was fixed in 3.3.0 by [MSHADE-252](https://issues.apache.org/jira/browse/MSHADE-252)
I can't understand what [MSHADE-252](https://issues.apache.org/jira/browse/MSHADE-252) has to do with relocation of classes. In [MSHADE-252](https://issues.apache.org/jira/browse/MSHADE-252) it is about the correct generation of Java source files. There was even another issue [MSHADE-396](https://issues.apache.org/jira/browse/MSHADE-396) which I opened and closed with the help of @kriegaex.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] Reamer commented on pull request #4545: CI broken
Posted by GitBox <gi...@apache.org>.
Reamer commented on PR #4545:
URL: https://github.com/apache/zeppelin/pull/4545#issuecomment-1380118193
Spark CI-Jobs seems to be running without errors.
https://github.com/apache/zeppelin/actions/runs/3894046270/jobs/6660597445
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] pan3793 commented on a diff in pull request #4545: CI broken
Posted by GitBox <gi...@apache.org>.
pan3793 commented on code in PR #4545:
URL: https://github.com/apache/zeppelin/pull/4545#discussion_r1065327386
##########
zeppelin-interpreter-shaded/pom.xml:
##########
@@ -33,7 +33,7 @@
<description>Zeppelin Interpreter Shaded</description>
<properties>
- <shaded.dependency.prefix>org.apache.zeppelin.shaded</shaded.dependency.prefix>
+ <shaded.dependency.prefix>shaded</shaded.dependency.prefix>
Review Comment:
If there is still an issue with relocating into its own sub-package, I would recommend changing it to `shaded.org.apache.zeppelin` instead of a common `shaded`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] jongyoul commented on pull request #4545: CI broken
Posted by GitBox <gi...@apache.org>.
jongyoul commented on PR #4545:
URL: https://github.com/apache/zeppelin/pull/4545#issuecomment-1381318657
https://github.com/conda-incubator/setup-miniconda/issues/274
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] Reamer commented on pull request #4545: CI broken
Posted by GitBox <gi...@apache.org>.
Reamer commented on PR #4545:
URL: https://github.com/apache/zeppelin/pull/4545#issuecomment-1378852906
The following error seems to be a maven reactor issue. Running the tests with ` -am -Dtest=org/apache/zeppelin/spark/*` seems to solve the issue (at least on my local machine)
```
2023-01-06T17:43:32.9579892Z [ERROR] testIPythonProcessKilled Time elapsed: 3.305 s <<< ERROR!
2023-01-06T17:43:32.9588899Z org.apache.zeppelin.interpreter.InterpreterException: java.lang.NoClassDefFoundError: io/grpc/stub/StreamObserver
2023-01-06T17:43:32.9597447Z at org.apache.zeppelin.spark.IPySparkInterpreterTest.startInterpreter(IPySparkInterpreterTest.java:98)
2023-01-06T17:43:32.9604208Z Caused by: java.lang.NoClassDefFoundError: io/grpc/stub/StreamObserver
2023-01-06T17:43:32.9612809Z at org.apache.zeppelin.spark.IPySparkInterpreterTest.startInterpreter(IPySparkInterpreterTest.java:98)
2023-01-06T17:43:32.9619547Z Caused by: java.lang.ClassNotFoundException: io.grpc.stub.StreamObserver
2023-01-06T17:43:32.9627967Z at org.apache.zeppelin.spark.IPySparkInterpreterTest.startInterpreter(IPySparkInterpreterTest.java:98)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] Reamer commented on a diff in pull request #4545: CI broken
Posted by GitBox <gi...@apache.org>.
Reamer commented on code in PR #4545:
URL: https://github.com/apache/zeppelin/pull/4545#discussion_r1073656877
##########
python/src/test/java/org/apache/zeppelin/python/IPythonInterpreterTest.java:
##########
@@ -434,9 +434,6 @@ public void run() {
InterpreterResult result = interpreter.interpret("import time\ntime.sleep(1000)",
getInterpreterContext());
waiter.assertEquals(InterpreterResult.Code.ERROR, result.code());
- waiter.assertEquals(
- "IPython kernel is abnormally exited, please check your code and log.",
- result.message().get(0).getData());
Review Comment:
During my tests `result.message()` was always `null`. We can investigate this later, as this has nothing to do with the issue.
In the summary of https://github.com/apache/zeppelin/actions/runs/3939354095 you can also see several errors which have errors because of this `null`.
The `0` errors indicate the `null` error:
After clicking on the message, the exception is displayed.
If you then look in the affected line, you will see a similar line.
https://github.com/apache/zeppelin/blob/0209d0d0d40e979bd284d89ec3eb6a90a34bf84a/spark/interpreter/src/test/java/org/apache/zeppelin/spark/SparkIRInterpreterTest.java#L110-L128
You should not make assertions within additional threads. See also: https://rules.sonarsource.com/java/RSPEC-2186
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] Reamer commented on pull request #4545: CI broken
Posted by GitBox <gi...@apache.org>.
Reamer commented on PR #4545:
URL: https://github.com/apache/zeppelin/pull/4545#issuecomment-1387192701
> I think it's good but I just have one question. Is there any critical reason that we changed `test` to `verify`? It looks similar and `verify` is running after `test` and `package`, and sometimes it uses more time. So I just wonder why `verify` is better than `test` in our cases.
You are correct that `verify` comes far after `test` in the Maven lifecycle. This is required to enrich the Maven Reactor with the necessary artefacts (phase `package`).
My goal is to remove the `install` step, which usually comes before any `test`. This would then save time again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] Reamer commented on pull request #4545: CI broken
Posted by GitBox <gi...@apache.org>.
Reamer commented on PR #4545:
URL: https://github.com/apache/zeppelin/pull/4545#issuecomment-1373780697
```
Caused by: java.lang.ClassNotFoundException: org/apache/zeppelin/shaded/org.apache.zeppelin.shaded.org.apache.commons.pool2.impl.DefaultEvictionPolicy
```
looks like a shading issue. I was doing a little reading about shading and came across the following comment. Therefore the shading prefix change.
> Please avoid shading a package into a subpackage of its own like com.fake to com.fake.shaded. You could potentially be getting some kind of recursive problem and depending on the algorithm used for replacing package and path names you could be lucky and it works or not. In your case it works for binaries because Maven Shade uses an ASM utility class for relocating binaries, which seems to do a good job.
https://issues.apache.org/jira/browse/MSHADE-252?focusedCommentId=17314377&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17314377
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] jongyoul commented on pull request #4545: CI broken
Posted by GitBox <gi...@apache.org>.
jongyoul commented on PR #4545:
URL: https://github.com/apache/zeppelin/pull/4545#issuecomment-1381314053
BTW, I see some different outputs for CI as well. Do you have any idea?
<img width="692" alt="image" src="https://user-images.githubusercontent.com/3612566/212240504-1def015b-859b-4a97-8c81-ec0a55cffd6f.png">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] Reamer commented on pull request #4545: CI broken
Posted by GitBox <gi...@apache.org>.
Reamer commented on PR #4545:
URL: https://github.com/apache/zeppelin/pull/4545#issuecomment-1373918746
Next error
ยดยดยด
Error: Failed to execute goal org.apache.maven.plugins:maven-shade-plugin:3.2.2:shade (default) on project zeppelin-jupyter-interpreter-shaded: Error creating shaded jar: duplicate entry: META-INF/services/org.apache.zeppelin.jupyter.io.grpc.NameResolverProvider -> [Help 1]
Error:
Error: To see the full stack trace of the errors, re-run Maven with the -e switch.
Error: Re-run Maven using the -X switch to enable full debug logging.
Error:
Error: For more information about the errors and possible solutions, please read the following articles:
Error: [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException
Error:
Error: After correcting the problems, you can resume the build with the command
Error: mvn <args> -rf :zeppelin-jupyter-interpreter-shaded
Error: Process completed with exit code 1.
```
Looks like the following issue [MSHADE-425](https://issues.apache.org/jira/browse/MSHADE-425)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] jongyoul commented on a diff in pull request #4545: CI broken
Posted by GitBox <gi...@apache.org>.
jongyoul commented on code in PR #4545:
URL: https://github.com/apache/zeppelin/pull/4545#discussion_r1080757497
##########
zeppelin-zengine/pom.xml:
##########
@@ -304,10 +304,6 @@
</executions>
</plugin>
- <plugin>
Review Comment:
Yeah, this kind of step is too hard to debug by IDE, but, unfortunately, Zeppelin has a bit lot of these types of modification. Hopefully, I would like to reduce/remove them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] Reamer commented on pull request #4545: CI broken
Posted by GitBox <gi...@apache.org>.
Reamer commented on PR #4545:
URL: https://github.com/apache/zeppelin/pull/4545#issuecomment-1385569897
The tests are running through. I will clean up the PR now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] jongyoul commented on pull request #4545: CI broken
Posted by GitBox <gi...@apache.org>.
jongyoul commented on PR #4545:
URL: https://github.com/apache/zeppelin/pull/4545#issuecomment-1381324679
I made #4550
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] Reamer commented on a diff in pull request #4545: CI broken
Posted by GitBox <gi...@apache.org>.
Reamer commented on code in PR #4545:
URL: https://github.com/apache/zeppelin/pull/4545#discussion_r1073665797
##########
zeppelin-zengine/pom.xml:
##########
@@ -304,10 +304,6 @@
</executions>
</plugin>
- <plugin>
Review Comment:
It took me a long time to figure out that this execution breaks the Maven build.
Until a few hours ago, I thought that this execution was just putting the dependencies under a location. What I didn't know is that this step also adds the dependency to the Maven reactor. This has led to various duplicate libraries within the Maven build, up to and including serious errors. It was hard to debug because the IDE ignores these dependencies.
The funny or sad thing, the build step is completely unnecessary.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] Reamer commented on pull request #4545: [ZEPPELIN-5861] Correct shading Prefix
Posted by "Reamer (via GitHub)" <gi...@apache.org>.
Reamer commented on PR #4545:
URL: https://github.com/apache/zeppelin/pull/4545#issuecomment-1400269014
Can someone do a review?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] pan3793 commented on a diff in pull request #4545: CI broken
Posted by GitBox <gi...@apache.org>.
pan3793 commented on code in PR #4545:
URL: https://github.com/apache/zeppelin/pull/4545#discussion_r1064020760
##########
zeppelin-interpreter-shaded/pom.xml:
##########
@@ -33,7 +33,7 @@
<description>Zeppelin Interpreter Shaded</description>
<properties>
- <shaded.dependency.prefix>org.apache.zeppelin.shaded</shaded.dependency.prefix>
+ <shaded.dependency.prefix>shaded</shaded.dependency.prefix>
Review Comment:
is it necessary? I believe it was fixed in 3.3.0 by [MSHADE-252](https://issues.apache.org/jira/browse/MSHADE-252)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] Reamer commented on a diff in pull request #4545: CI broken
Posted by GitBox <gi...@apache.org>.
Reamer commented on code in PR #4545:
URL: https://github.com/apache/zeppelin/pull/4545#discussion_r1065427653
##########
zeppelin-interpreter-shaded/pom.xml:
##########
@@ -33,7 +33,7 @@
<description>Zeppelin Interpreter Shaded</description>
<properties>
- <shaded.dependency.prefix>org.apache.zeppelin.shaded</shaded.dependency.prefix>
+ <shaded.dependency.prefix>shaded</shaded.dependency.prefix>
Review Comment:
At the moment there is nothing wrong with your suggested prefix, I have changed this and thank you for your opinion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org