[GitHub] [camel] omarsmak commented on pull request #5201: CAMEL-16343: Avoid committing offsets on onPartitionsRevoked in case the user committing offsets

[GitBox <gi...@apache.org>]

omarsmak commented on pull request #5201:
URL: https://github.com/apache/camel/pull/5201#issuecomment-808272418


   > Hi,
   > I think you also need to check what is the value of autoCommitOnStop during shutdown.
   > 
   > As of now, during shutdown - kafka revoke the assigned partition, and then it is forcing commitSync
   > 
   > ```
   > DEBUG org.apache.camel.component.kafka.KafkaConsumer: - onPartitionsRevoked: **-Thread 0 from topic **
   > 
   > DEBUG org.apache.camel.component.kafka.KafkaConsumer: - Forcing commitSync **-Thread 0 from topic ** with offset: 31621
   > ```
   > 
   > if condition should be same as that in doRun() method
   
   Can you please create a JIRA ticket for it? Would be great if you send us a PR to fix it :)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org