You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/09/10 01:40:19 UTC

[GitHub] [pulsar] coderzc commented on pull request #17575: [cleanup][broker] Use set instead of list to improve `contains` and `containsAll` performance.

coderzc commented on PR #17575:
URL: https://github.com/apache/pulsar/pull/17575#issuecomment-1242590573

   > LGTM. I'd like to know whether this code change is on the hot path (critical path).
   > 
   > That is, if we make minor improvements outside hot paths, it's OK but not very valuable. If you made the change on a critical path and stated a performance improvement, is there any (micro) performance report for the diff?
   
   This is just a minor improvement, I think it is a good programming practice.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org