You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by "qingwli (via GitHub)" <gi...@apache.org> on 2024/05/10 07:40:47 UTC
[PR] [Improvement][Monitor] Show master && worker Busy Or Normal Status and Show Commands table list [dolphinscheduler]
qingwli opened a new pull request, #15978:
URL: https://github.com/apache/dolphinscheduler/pull/15978
- clost #15977
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Improvement][Monitor] Show master && worker Busy Or Normal Status and Show Commands table list [dolphinscheduler]
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #15978:
URL: https://github.com/apache/dolphinscheduler/pull/15978#issuecomment-2111642584
## [](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=15978) **Quality Gate failed**
Failed conditions
 [5.1% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=15978&metric=new_coverage&view=list) (required ≥ 60%)
 [B Reliability Rating on New Code](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=15978) (required ≥ A)
[See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=15978)
##
 Catch issues before they fail your Quality Gate with our IDE extension  [SonarLint](https://www.sonarsource.com/products/sonarlint/features/connected-mode/?referrer=pull-request)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Improvement][Monitor] Show master && worker Busy Or Normal Status and Show Commands table list [dolphinscheduler]
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #15978:
URL: https://github.com/apache/dolphinscheduler/pull/15978#issuecomment-2104172183
## [](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=15978) **Quality Gate failed**
Failed conditions
 [5.1% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=15978&metric=new_coverage&view=list) (required ≥ 60%)
 [B Reliability Rating on New Code](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=15978) (required ≥ A)
[See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=15978)
##
 Catch issues before they fail your Quality Gate with our IDE extension  [SonarLint](https://www.sonarsource.com/products/sonarlint/features/connected-mode/?referrer=pull-request)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Improvement][Monitor] Show master && worker Busy Or Normal Status and Show Commands table list [dolphinscheduler]
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #15978:
URL: https://github.com/apache/dolphinscheduler/pull/15978#issuecomment-2111500487
## [](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=15978) **Quality Gate failed**
Failed conditions
 [5.1% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=15978&metric=new_coverage&view=list) (required ≥ 60%)
 [B Reliability Rating on New Code](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=15978) (required ≥ A)
[See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=15978)
##
 Catch issues before they fail your Quality Gate with our IDE extension  [SonarLint](https://www.sonarsource.com/products/sonarlint/features/connected-mode/?referrer=pull-request)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Improvement][Monitor] Show master && worker Busy Or Normal Status and Show Commands table list [dolphinscheduler]
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #15978:
URL: https://github.com/apache/dolphinscheduler/pull/15978#issuecomment-2104348099
Please retry analysis of this Pull-Request directly on SonarCloud
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Improvement][Monitor] Show master && worker Busy Or Normal Status and Show Commands table list [dolphinscheduler]
Posted by "qingwli (via GitHub)" <gi...@apache.org>.
qingwli commented on PR #15978:
URL: https://github.com/apache/dolphinscheduler/pull/15978#issuecomment-2104143485
> Please put some pictures in the document. @qingwli
OK, Will update later
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Improvement][Monitor] Show master && worker Busy Or Normal Status and Show Commands table list [dolphinscheduler]
Posted by "qingwli (via GitHub)" <gi...@apache.org>.
qingwli commented on code in PR #15978:
URL: https://github.com/apache/dolphinscheduler/pull/15978#discussion_r1599544052
##########
dolphinscheduler-dao/src/main/resources/org/apache/dolphinscheduler/dao/mapper/ProcessDefinitionMapper.xml:
##########
@@ -208,4 +208,17 @@
SELECT DISTINCT(id) as project_id
FROM t_ds_project
</select>
+
+ <select id="queryDefinitionCodeListByProjectCodes" resultType="java.lang.Long">
+ select
+ code
+ from t_ds_process_definition
+ where 1=1
+ <if test="projectCodes != null and projectCodes.size() != 0">
+ and project_code in
+ <foreach collection="projectCodes" index="index" item="i" open="(" separator="," close=")">
+ #{i}
+ </foreach>
+ </if>
Review Comment:
No, User just can see the project which authed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Improvement][Monitor] Show master && worker Busy Or Normal Status and Show Commands table list [dolphinscheduler]
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #15978:
URL: https://github.com/apache/dolphinscheduler/pull/15978#issuecomment-2104347511
## [](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=15978) **Quality Gate failed**
Failed conditions
 [5.1% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=15978&metric=new_coverage&view=list) (required ≥ 60%)
 [B Reliability Rating on New Code](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=15978) (required ≥ A)
[See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=15978)
##
 Catch issues before they fail your Quality Gate with our IDE extension  [SonarLint](https://www.sonarsource.com/products/sonarlint/features/connected-mode/?referrer=pull-request)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Improvement][Monitor] Show master && worker Busy Or Normal Status and Show Commands table list [dolphinscheduler]
Posted by "rickchengx (via GitHub)" <gi...@apache.org>.
rickchengx commented on code in PR #15978:
URL: https://github.com/apache/dolphinscheduler/pull/15978#discussion_r1597368151
##########
dolphinscheduler-dao/src/main/resources/sql/dolphinscheduler_h2.sql:
##########
@@ -2183,4 +2183,4 @@ CREATE TABLE t_ds_listener_event
PRIMARY KEY (id),
KEY idx_status (post_status),
KEY idx_event_sign (sign)
-);
+);
Review Comment:
Is this necessary? This may be related to one of the CI error
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Improvement][Monitor] Show master && worker Busy Or Normal Status and Show Commands table list [dolphinscheduler]
Posted by "qingwli (via GitHub)" <gi...@apache.org>.
qingwli merged PR #15978:
URL: https://github.com/apache/dolphinscheduler/pull/15978
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Improvement][Monitor] Show master && worker Busy Or Normal Status and Show Commands table list [dolphinscheduler]
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #15978:
URL: https://github.com/apache/dolphinscheduler/pull/15978#issuecomment-2109703200
## [](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=15978) **Quality Gate failed**
Failed conditions
 [5.1% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=15978&metric=new_coverage&view=list) (required ≥ 60%)
 [B Reliability Rating on New Code](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=15978) (required ≥ A)
[See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=15978)
##
 Catch issues before they fail your Quality Gate with our IDE extension  [SonarLint](https://www.sonarsource.com/products/sonarlint/features/connected-mode/?referrer=pull-request)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Improvement][Monitor] Show master && worker Busy Or Normal Status and Show Commands table list [dolphinscheduler]
Posted by "ruanwenjun (via GitHub)" <gi...@apache.org>.
ruanwenjun commented on PR #15978:
URL: https://github.com/apache/dolphinscheduler/pull/15978#issuecomment-2104422478
Since this is compatible with 3.2.1, so I change the milestone to 3.2.2.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Improvement][Monitor] Show master && worker Busy Or Normal Status and Show Commands table list [dolphinscheduler]
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #15978:
URL: https://github.com/apache/dolphinscheduler/pull/15978#issuecomment-2105608792
## [](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=15978) **Quality Gate failed**
Failed conditions
 [5.1% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=15978&metric=new_coverage&view=list) (required ≥ 60%)
 [B Reliability Rating on New Code](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=15978) (required ≥ A)
[See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=15978)
##
 Catch issues before they fail your Quality Gate with our IDE extension  [SonarLint](https://www.sonarsource.com/products/sonarlint/features/connected-mode/?referrer=pull-request)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Improvement][Monitor] Show master && worker Busy Or Normal Status and Show Commands table list [dolphinscheduler]
Posted by "ruanwenjun (via GitHub)" <gi...@apache.org>.
ruanwenjun commented on code in PR #15978:
URL: https://github.com/apache/dolphinscheduler/pull/15978#discussion_r1597559003
##########
dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/controller/DataAnalysisController.java:
##########
@@ -148,4 +152,54 @@ public Result<Map<String, Integer>> countQueueState(@Parameter(hidden = true) @R
Map<String, Integer> stringIntegerMap = dataAnalysisService.countQueueState(loginUser);
return Result.success(stringIntegerMap);
}
+
+ /**
+ * command queue
+ *
+ * @param loginUser login user
+ * @return queue state count
+ */
+ @Operation(summary = "listQueueCommand", description = "LIST_QUEUE_COMMAND_LIST_PAGING_NOTES")
+ @Parameters({
+ @Parameter(name = "searchVal", description = "SEARCH_VAL", schema = @Schema(implementation = String.class)),
+ @Parameter(name = "pageNo", description = "PAGE_NO", required = true, schema = @Schema(implementation = int.class, example = "1")),
+ @Parameter(name = "pageSize", description = "PAGE_SIZE", required = true, schema = @Schema(implementation = int.class, example = "20"))
+ })
+ @GetMapping("/listCommand")
+ @ResponseStatus(HttpStatus.OK)
+ @ApiException(LIST_PAGING_ALERT_GROUP_ERROR)
+ public Result<PageInfo<Command>> listPaging(@Parameter(hidden = true) @RequestAttribute(value = Constants.SESSION_USER) User loginUser,
+ @RequestParam(value = "projectCode", required = false) Long projectCode,
+ @RequestParam("pageNo") Integer pageNo,
+ @RequestParam("pageSize") Integer pageSize) {
+ checkPageParams(pageNo, pageSize);
+ PageInfo<Command> commandPageInfo =
+ dataAnalysisService.listQueueCommand(loginUser, projectCode, pageNo, pageSize);
Review Comment:
```suggestion
dataAnalysisService.listPendingCommands(loginUser, projectCode, pageNo, pageSize);
```
##########
dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/mapper/CommandMapper.java:
##########
@@ -50,12 +52,15 @@ List<CommandCount> countCommandState(
*
* @return
*/
- List<Command> queryCommandPage(@Param("limit") int limit, @Param("offset") int offset);
+ IPage<Command> queryCommandPage(Page<Command> page);
List<Command> queryCommandByIdSlot(@Param("currentSlotIndex") int currentSlotIndex,
@Param("totalSlot") int totalSlot,
@Param("idStep") int idStep,
@Param("fetchNumber") int fetchNum);
void deleteByWorkflowInstanceIds(@Param("workflowInstanceIds") List<Integer> workflowInstanceIds);
+
+ IPage<Command> queryCommandPageByIds(Page<Command> page, @Param("definitionCodes") List<Long> definitionCodes,
+ @Param("projectCode") Long projectCode);
Review Comment:
```suggestion
IPage<Command> queryCommandPageByIds(Page<Command> page, @Param("workflowDefinitionCodes") List<Long> workflowDefinitionCodes);
```
Please remove the projectCode at this method, this param is never used?
And use more accurate naming for definitionCodes, since there exist workflowDefinitionCodes and taskDefinitionCodes
##########
dolphinscheduler-dao/src/main/resources/org/apache/dolphinscheduler/dao/mapper/ErrorCommandMapper.xml:
##########
@@ -33,4 +33,26 @@
</if>
group by cmd.command_type
</select>
+
+ <select id="queryErrorCommandPage" resultType="org.apache.dolphinscheduler.dao.entity.ErrorCommand">
+ select
+ *
+ from t_ds_error_command
+ where 1 = 1
Review Comment:
```suggestion
```
##########
dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/controller/DataAnalysisController.java:
##########
@@ -148,4 +152,54 @@ public Result<Map<String, Integer>> countQueueState(@Parameter(hidden = true) @R
Map<String, Integer> stringIntegerMap = dataAnalysisService.countQueueState(loginUser);
return Result.success(stringIntegerMap);
}
+
+ /**
+ * command queue
+ *
+ * @param loginUser login user
+ * @return queue state count
+ */
+ @Operation(summary = "listQueueCommand", description = "LIST_QUEUE_COMMAND_LIST_PAGING_NOTES")
Review Comment:
```suggestion
@Operation(summary = "listPendingCommands", description = "LIST_PENDING_COMMANDS")
```
##########
dolphinscheduler-dao/src/main/resources/org/apache/dolphinscheduler/dao/mapper/ProcessDefinitionMapper.xml:
##########
@@ -208,4 +208,17 @@
SELECT DISTINCT(id) as project_id
FROM t_ds_project
</select>
+
+ <select id="queryDefinitionCodeListByProjectCodes" resultType="java.lang.Long">
+ select
+ code
+ from t_ds_process_definition
+ where 1=1
+ <if test="projectCodes != null and projectCodes.size() != 0">
+ and project_code in
+ <foreach collection="projectCodes" index="index" item="i" open="(" separator="," close=")">
+ #{i}
+ </foreach>
+ </if>
Review Comment:
If the `projectCodes` is a required param, we would better not check it is empty here, if someone call this method but forget to set the projectCodes, it will get all workflow definition codes.
```suggestion
where project_code in
<foreach collection="projectCodes" index="index" item="i" open="(" separator="," close=")">
#{i}
</foreach>
```
##########
dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/mapper/ErrorCommandMapper.java:
##########
@@ -43,4 +45,10 @@ List<CommandCount> countCommandState(
@Param("startTime") Date startTime,
@Param("endTime") Date endTime,
@Param("projectCodes") List<Long> projectCodes);
+
+ IPage<ErrorCommand> queryErrorCommandPage(Page<ErrorCommand> page);
+
+ IPage<ErrorCommand> queryErrorCommandPageByIds(Page<ErrorCommand> page,
+ @Param("definitionCodes") List<Long> definitionCodes,
+ @Param("projectCode") Long projectCode);
Review Comment:
```suggestion
IPage<ErrorCommand> queryErrorCommandPageByIds(Page<ErrorCommand> page,
@Param("workflowDefinitionCodes") List<Long> workflowDefinitionCodes);
```
Please remove the projectCode at this method, this param is never used?
And use more accurate naming for `definitionCodes`, since there exist `workflowDefinitionCodes` and `taskDefinitionCodes`
##########
dolphinscheduler-dao/src/main/resources/org/apache/dolphinscheduler/dao/mapper/ErrorCommandMapper.xml:
##########
@@ -33,4 +33,26 @@
</if>
group by cmd.command_type
</select>
+
+ <select id="queryErrorCommandPage" resultType="org.apache.dolphinscheduler.dao.entity.ErrorCommand">
+ select
+ *
+ from t_ds_error_command
+ where 1 = 1
+ order by process_instance_priority, id asc
+ </select>
+
+ <select id="queryErrorCommandPageByIds" resultType="org.apache.dolphinscheduler.dao.entity.ErrorCommand">
+ select
+ *
+ from t_ds_error_command
+ where 1 = 1
+ <if test="definitionCodes != null and definitionCodes.size() > 0">
+ and process_definition_code in
+ <foreach item="id" index="index" collection="definitionCodes" open="(" separator="," close=")">
+ #{id}
+ </foreach>
+ </if>
Review Comment:
```suggestion
where process_definition_code in
<foreach item="id" index="index" collection="definitionCodes" open="(" separator="," close=")">
#{id}
</foreach>
```
If the workflowDefinitionCodes is a required param, we would better not check it is empty here, if someone call this method but forget to set the workflowDefinitionCodes, it will get all commands.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Improvement][Monitor] Show master && worker Busy Or Normal Status and Show Commands table list [dolphinscheduler]
Posted by "qingwli (via GitHub)" <gi...@apache.org>.
qingwli commented on PR #15978:
URL: https://github.com/apache/dolphinscheduler/pull/15978#issuecomment-2111474031
I will add some UT later
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Improvement][Monitor] Show master && worker Busy Or Normal Status and Show Commands table list [dolphinscheduler]
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #15978:
URL: https://github.com/apache/dolphinscheduler/pull/15978#issuecomment-2104174775
## [](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=15978) **Quality Gate failed**
Failed conditions
 [5.1% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=15978&metric=new_coverage&view=list) (required ≥ 60%)
 [B Reliability Rating on New Code](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=15978) (required ≥ A)
[See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=15978)
##
 Catch issues before they fail your Quality Gate with our IDE extension  [SonarLint](https://www.sonarsource.com/products/sonarlint/features/connected-mode/?referrer=pull-request)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Improvement][Monitor] Show master && worker Busy Or Normal Status and Show Commands table list [dolphinscheduler]
Posted by "qingwli (via GitHub)" <gi...@apache.org>.
qingwli commented on PR #15978:
URL: https://github.com/apache/dolphinscheduler/pull/15978#issuecomment-2104239829
@SbloodyS Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Improvement][Monitor] Show master && worker Busy Or Normal Status and Show Commands table list [dolphinscheduler]
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #15978:
URL: https://github.com/apache/dolphinscheduler/pull/15978#issuecomment-2109699990
## [](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=15978) **Quality Gate failed**
Failed conditions
 [5.1% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=15978&metric=new_coverage&view=list) (required ≥ 60%)
 [B Reliability Rating on New Code](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=15978) (required ≥ A)
[See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=15978)
##
 Catch issues before they fail your Quality Gate with our IDE extension  [SonarLint](https://www.sonarsource.com/products/sonarlint/features/connected-mode/?referrer=pull-request)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Improvement][Monitor] Show master && worker Busy Or Normal Status and Show Commands table list [dolphinscheduler]
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #15978:
URL: https://github.com/apache/dolphinscheduler/pull/15978#issuecomment-2111500587
Please retry analysis of this Pull-Request directly on SonarCloud
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Improvement][Monitor] Show master && worker Busy Or Normal Status and Show Commands table list [dolphinscheduler]
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #15978:
URL: https://github.com/apache/dolphinscheduler/pull/15978#issuecomment-2111641801
## [](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=15978) **Quality Gate failed**
Failed conditions
 [5.1% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=15978&metric=new_coverage&view=list) (required ≥ 60%)
 [B Reliability Rating on New Code](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=15978) (required ≥ A)
[See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=15978)
##
 Catch issues before they fail your Quality Gate with our IDE extension  [SonarLint](https://www.sonarsource.com/products/sonarlint/features/connected-mode/?referrer=pull-request)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Improvement][Monitor] Show master && worker Busy Or Normal Status and Show Commands table list [dolphinscheduler]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #15978:
URL: https://github.com/apache/dolphinscheduler/pull/15978#issuecomment-2104162994
## [Codecov](https://app.codecov.io/gh/apache/dolphinscheduler/pull/15978?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
Attention: Patch coverage is `6.66667%` with `42 lines` in your changes are missing coverage. Please review.
> Project coverage is 39.86%. Comparing base [(`ace20f9`)](https://app.codecov.io/gh/apache/dolphinscheduler/commit/ace20f96c27215d5d8c84ee0b193bfc1672c8ae3?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`a6edf17`)](https://app.codecov.io/gh/apache/dolphinscheduler/pull/15978?dropdown=coverage&src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
> :exclamation: Current head a6edf17 differs from pull request most recent head 4b7553e. Consider uploading reports for the commit 4b7553e to get more accurate results
| [Files](https://app.codecov.io/gh/apache/dolphinscheduler/pull/15978?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...uler/api/service/impl/DataAnalysisServiceImpl.java](https://app.codecov.io/gh/apache/dolphinscheduler/pull/15978?src=pr&el=tree&filepath=dolphinscheduler-api%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fdolphinscheduler%2Fapi%2Fservice%2Fimpl%2FDataAnalysisServiceImpl.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3NlcnZpY2UvaW1wbC9EYXRhQW5hbHlzaXNTZXJ2aWNlSW1wbC5qYXZh) | 0.00% | [33 Missing :warning: ](https://app.codecov.io/gh/apache/dolphinscheduler/pull/15978?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...heduler/api/controller/DataAnalysisController.java](https://app.codecov.io/gh/apache/dolphinscheduler/pull/15978?src=pr&el=tree&filepath=dolphinscheduler-api%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fdolphinscheduler%2Fapi%2Fcontroller%2FDataAnalysisController.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL2NvbnRyb2xsZXIvRGF0YUFuYWx5c2lzQ29udHJvbGxlci5qYXZh) | 0.00% | [8 Missing :warning: ](https://app.codecov.io/gh/apache/dolphinscheduler/pull/15978?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...cheduler/api/service/impl/ExecutorServiceImpl.java](https://app.codecov.io/gh/apache/dolphinscheduler/pull/15978?src=pr&el=tree&filepath=dolphinscheduler-api%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fdolphinscheduler%2Fapi%2Fservice%2Fimpl%2FExecutorServiceImpl.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3NlcnZpY2UvaW1wbC9FeGVjdXRvclNlcnZpY2VJbXBsLmphdmE=) | 50.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/dolphinscheduler/pull/15978?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## dev #15978 +/- ##
============================================
- Coverage 39.86% 39.86% -0.01%
- Complexity 5060 5073 +13
============================================
Files 1369 1369
Lines 45635 45582 -53
Branches 4869 4863 -6
============================================
- Hits 18193 18171 -22
+ Misses 25544 25511 -33
- Partials 1898 1900 +2
```
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/dolphinscheduler/pull/15978?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Improvement][Monitor] Show master && worker Busy Or Normal Status and Show Commands table list [dolphinscheduler]
Posted by "qingwli (via GitHub)" <gi...@apache.org>.
qingwli commented on code in PR #15978:
URL: https://github.com/apache/dolphinscheduler/pull/15978#discussion_r1597372125
##########
dolphinscheduler-dao/src/main/resources/sql/dolphinscheduler_h2.sql:
##########
@@ -2183,4 +2183,4 @@ CREATE TABLE t_ds_listener_event
PRIMARY KEY (id),
KEY idx_status (post_status),
KEY idx_event_sign (sign)
-);
+);
Review Comment:
Recover this file
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Improvement][Monitor] Show master && worker Busy Or Normal Status and Show Commands table list [dolphinscheduler]
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #15978:
URL: https://github.com/apache/dolphinscheduler/pull/15978#issuecomment-2105608886
## [](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=15978) **Quality Gate failed**
Failed conditions
 [5.1% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=15978&metric=new_coverage&view=list) (required ≥ 60%)
 [B Reliability Rating on New Code](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=15978) (required ≥ A)
[See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=15978)
##
 Catch issues before they fail your Quality Gate with our IDE extension  [SonarLint](https://www.sonarsource.com/products/sonarlint/features/connected-mode/?referrer=pull-request)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org